clarify hir_id <-> node_id method names #70480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
approved these changes
Mar 27, 2020
|
@bors r+ Thanks! |
|
📌 Commit 37603f4 has been approved by |
bors
added
the
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 27, 2020
clarify hir_id <-> node_id method names resolves 2 FIXME. r? @eddyb
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70345 (Remove `no_integrated_as` mode.) - rust-lang#70434 (suggest `;` on expr `mac!()` which is good as stmt `mac!()`) - rust-lang#70457 (non-exhastive diagnostic: add note re. scrutinee type) - rust-lang#70478 (Refactor type_of for constants) - rust-lang#70480 (clarify hir_id <-> node_id method names) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves 2 FIXME.
r? @eddyb