Rollup of 5 pull requests #70483
Merged
Rollup of 5 pull requests #70483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, remove both `-Z no_integrated_as` and `TargetOptions::no_integrated_as`. The latter was only used for the `msp430_none_elf` platform, for which it's no longer required.
…alexcrichton Remove `no_integrated_as` mode. Specifically, remove both `-Z no_integrated_as` and `TargetOptions::no_integrated_as`. The latter was only used for the `msp430_none_elf` platform, for which it's no longer required. r? @alexcrichton
suggest `;` on expr `mac!()` which is good as stmt `mac!()` Fixes rust-lang#34421 by implementing @jseyfried's suggestion in rust-lang#34421 (comment). r? @petrochenkov
…pe, r=estebank non-exhastive diagnostic: add note re. scrutinee type This fixes rust-lang#67259 by adding a note: ``` = note: the matched value is of type &[i32] ``` to non-exhaustive pattern matching errors. r? @varkor @estebank
Refactor type_of for constants If I have to look at this function for a few hours I want it to at least look good. r? @varkor
clarify hir_id <-> node_id method names resolves 2 FIXME. r? @eddyb
|
@bors r+ p=5 rollup=never |
|
📌 Commit a023e61 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
no_integrated_asmode. #70345 (Removeno_integrated_asmode.);on exprmac!()which is good as stmtmac!()#70434 (suggest;on exprmac!()which is good as stmtmac!())Failed merges:
r? @ghost