Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #70427

Merged
merged 27 commits into from
Mar 26, 2020
Merged

Rollup of 5 pull requests #70427

merged 27 commits into from
Mar 26, 2020

Commits on Mar 25, 2020

  1. Configuration menu
    Copy the full SHA
    4920a33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b5343d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d77d01 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    81006f6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb3e513 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Throw error when encountering ... instead of .. while destructing…

    … a pattern
    
    Added tests and stderr output
    rakshith-ravi committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    73c8203 View commit details
    Browse the repository at this point in the history
  2. simplify match stmt

    lcnr committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    c21e25c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e8a05e2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6507170 View commit details
    Browse the repository at this point in the history
  5. introduce negative_impls feature gate and document

    They used to be covered by `optin_builtin_traits` but negative impls
    are now applicable to all traits, not just auto traits.
    
    This also adds docs in the unstable book for the current state of auto traits.
    nikomatsakis committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    fda3378 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc0d6d0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    68aa798 View commit details
    Browse the repository at this point in the history
  8. convert to doc comments

    nikomatsakis committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    73a5500 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f662847 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7107f6e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    644b9a0 View commit details
    Browse the repository at this point in the history
  12. move stderr file too

    nikomatsakis committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    f5c09ed View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b9e09d8 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    c35801e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    011215b View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    0d07026 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0b00c20 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#68004 - nikomatsakis:negative-impls, r=varkor

    permit negative impls for non-auto traits
    
    This is a prototype impl that extends `impl !Trait` beyond auto traits. It is not integrated with coherence or anything else, and hence only serves to prevent downstream impls (but not to allow downstream crates to rely on the absence of such impls for coherence purposes).
    
    Fixes rust-lang#66544
    
    TODO:
    
    - [x] need a test that you can't rely on negative impls for coherence purposes
    - [x] test that negative impls cannot specialize positive ones
    - [x] test that positive impls cannot specialize negative ones
    - [x] extend negative impl to `Clone` in order to fully fix rust-lang#66544
    - [x] and maybe make `CoerceUnsized` unsafe? -- that problem is now split out into rust-lang#68015
    - [x] introduce feature flag and prepare a write-up
    - [x] improve diagnostics?
    Centril authored Mar 26, 2020
    Configuration menu
    Copy the full SHA
    b0a63cb View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#70385 - RalfJung:miri-nits, r=eddyb

    Miri nits: comment and var name improvement
    
    r? @eddyb
    Centril authored Mar 26, 2020
    Configuration menu
    Copy the full SHA
    20771ae View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#70411 - ogoffart:fix-62691, r=eddyb

    Fix for rust-lang#62691: use the largest niche across all fields
    
    fixes rust-lang#62691
    
    (The second commit is a small optimization but it makes the code less pretty and i don't know if it is worth it.)
    Centril authored Mar 26, 2020
    Configuration menu
    Copy the full SHA
    f9d1378 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#70417 - rakshith-ravi:master, r=Centril

    parser: recover on `...` as a pattern, suggesting `..`
    
    Fixes rust-lang#70388
    
    My first PR to rust. So please let me know if I'm doing something wrong.
    Centril authored Mar 26, 2020
    Configuration menu
    Copy the full SHA
    37e1860 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#70424 - lcnr:nit, r=Centril

    simplify match stmt
    
    We actually have a surprising amount of
    ```rust
    match expr {
        $($p:pat)|+ => true,
        _ => false,
    }
    ```
    While I would prefer this to be replaced with `matches!`, most cases are
    fairly readable anyway so we can just let them be for now.
    Centril authored Mar 26, 2020
    Configuration menu
    Copy the full SHA
    608715b View commit details
    Browse the repository at this point in the history