Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miri nits: comment and var name improvement #70385

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Miri nits: comment and var name improvement #70385

merged 2 commits into from
Mar 26, 2020

Conversation

RalfJung
Copy link
Member

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2020
@eddyb
Copy link
Member

eddyb commented Mar 26, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2020

📌 Commit b5343d6 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 26, 2020
@Centril
Rollup merge of rust-lang#70385 - RalfJung:miri-nits, r=eddyb
c33fd53 
Miri nits: comment and var name improvement

r? @eddyb
@Centril Centril mentioned this pull request Mar 26, 2020
Closed
@RalfJung
Copy link
Member Author

@bors rollup

@Centril Centril mentioned this pull request Mar 26, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2020
@bors
Auto merge of rust-lang#70427 - Centril:rollup-lrcad2c, r=Centril
2fbb075 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#68004 (permit negative impls for non-auto traits)
 - rust-lang#70385 (Miri nits: comment and var name improvement)
 - rust-lang#70411 (Fix for rust-lang#62691: use the largest niche across all fields)
 - rust-lang#70417 (parser: recover on `...` as a pattern, suggesting `..`)
 - rust-lang#70424 (simplify match stmt)

Failed merges:

r? @ghost
@bors bors merged commit 20771ae into rust-lang:master Mar 26, 2020
@RalfJung RalfJung deleted the miri-nits branch March 26, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @eddyb @bors @rust-highfive