Rollup of 5 pull requests #70427
Merged
Rollup of 5 pull requests #70427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a pattern Added tests and stderr output
They used to be covered by `optin_builtin_traits` but negative impls are now applicable to all traits, not just auto traits. This also adds docs in the unstable book for the current state of auto traits.
permit negative impls for non-auto traits This is a prototype impl that extends `impl !Trait` beyond auto traits. It is not integrated with coherence or anything else, and hence only serves to prevent downstream impls (but not to allow downstream crates to rely on the absence of such impls for coherence purposes). Fixes rust-lang#66544 TODO: - [x] need a test that you can't rely on negative impls for coherence purposes - [x] test that negative impls cannot specialize positive ones - [x] test that positive impls cannot specialize negative ones - [x] extend negative impl to `Clone` in order to fully fix rust-lang#66544 - [x] and maybe make `CoerceUnsized` unsafe? -- that problem is now split out into rust-lang#68015 - [x] introduce feature flag and prepare a write-up - [x] improve diagnostics?
Miri nits: comment and var name improvement r? @eddyb
Fix for rust-lang#62691: use the largest niche across all fields fixes rust-lang#62691 (The second commit is a small optimization but it makes the code less pretty and i don't know if it is worth it.)
parser: recover on `...` as a pattern, suggesting `..` Fixes rust-lang#70388 My first PR to rust. So please let me know if I'm doing something wrong.
simplify match stmt
We actually have a surprising amount of
```rust
match expr {
$($p:pat)|+ => true,
_ => false,
}
```
While I would prefer this to be replaced with `matches!`, most cases are
fairly readable anyway so we can just let them be for now.
|
@bors r+ p=5 rollup=never |
|
📌 Commit 608715b has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Mar 26, 2020
Tested on commit rust-lang/rust@2fbb075. Direct link to PR: <rust-lang/rust#70427> 💔 nomicon on windows: test-pass → test-fail (cc @Gankra @frewsxcv). 💔 nomicon on linux: test-pass → test-fail (cc @Gankra @frewsxcv).
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
...as a pattern, suggesting..#70417 (parser: recover on...as a pattern, suggesting..)Failed merges:
r? @ghost