Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run-make wasm tests #50787

Merged
merged 1 commit into from
May 17, 2018
Merged

Fix run-make wasm tests #50787

merged 1 commit into from
May 17, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 15, 2018

Fixes #50711

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2018
@ehuss
Copy link
Contributor Author

ehuss commented May 15, 2018 •
edited
Loading

I don't have a mingw setup to verify that the cross-lang-lto test is ignored, but I'm fairly confident that compiletest is picking up the directive and it should work.

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks so much @ehuss!

@bors
Copy link
Contributor

bors commented May 16, 2018

📌 Commit a90a963 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2018
@kennytm kennytm mentioned this pull request May 16, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request May 16, 2018
@kennytm
Rollup merge of rust-lang#50787 - ehuss:fix-run-make-wasm, r=alexcric…
9ced69d 
…hton

Fix run-make wasm tests

Fixes rust-lang#50711
bors added a commit that referenced this pull request May 17, 2018
@bors
Auto merge of #50807 - kennytm:rollup, r=kennytm
b559710 
Rollup of 17 pull requests

Successful merges:

 - #50170 (Implement From for more types on Cow)
 - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux)
 - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait)
 - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`)
 - #50726 (read2: Use inner function instead of closure)
 - #50728 (Fix rustdoc panic with `impl Trait` in type parameters)
 - #50736 (env: remove unwrap in examples in favor of try op)
 - #50740 (Remove LazyBTreeMap.)
 - #50752 (Add missing error codes in libsyntax-ext asm)
 - #50779 (Make mutable_noalias and arg_align_attributes be tracked)
 - #50787 (Fix run-make wasm tests)
 - #50788 (Fix an ICE when casting a nonexistent const)
 - #50789 (Ensure libraries built in stage0 have unique metadata)
 - #50793 (tidy: Add a check for empty UI test files)
 - #50797 (fix a typo in signed-integer::from_str_radix())
 - #50808 (Stabilize num::NonZeroU*)
 - #50809 (GitHub: Stop treating Cargo.lock as a generated file.)

Failed merges:
@bors bors merged commit a90a963 into rust-lang:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rust-highfive @alexcrichton @bors @nikomatsakis