-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env: remove unwrap in examples in favor of try op #50736
Conversation
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
I think I'm generally in favor of this, but I'm hesitant to accept it as-is because doctests will be getting the ability to use I could see if we used the +/// # fn main() -> std::io::Result<()> {
+/// let path = env::current_dir()?;
+/// println!("The current directory is {}", path.display());
+/// # Ok(())
+/// # } But I wonder if hiding the |
@shepmaster this is only documentation, we can patch it again when try-op is available for doctests. This change puts it in line with other similar doctests (e.g. https://doc.rust-lang.org/std/io/trait.Read.html) which will also have to be patched later. |
Ah, alright then. @bors r+ |
📌 Commit f73c4a4 has been approved by |
@bors rollup |
Thanks! |
env: remove unwrap in examples in favor of try op
Rollup of 17 pull requests Successful merges: - #50170 (Implement From for more types on Cow) - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux) - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait) - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`) - #50726 (read2: Use inner function instead of closure) - #50728 (Fix rustdoc panic with `impl Trait` in type parameters) - #50736 (env: remove unwrap in examples in favor of try op) - #50740 (Remove LazyBTreeMap.) - #50752 (Add missing error codes in libsyntax-ext asm) - #50779 (Make mutable_noalias and arg_align_attributes be tracked) - #50787 (Fix run-make wasm tests) - #50788 (Fix an ICE when casting a nonexistent const) - #50789 (Ensure libraries built in stage0 have unique metadata) - #50793 (tidy: Add a check for empty UI test files) - #50797 (fix a typo in signed-integer::from_str_radix()) - #50808 (Stabilize num::NonZeroU*) - #50809 (GitHub: Stop treating Cargo.lock as a generated file.) Failed merges:
No description provided.