Make Solaris builder compatible with Solaris 10 retry #45343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, #45255 does not quite cut it, so use a different approach to have Solaris 10 compatibility by tricking libbacktrace's autoconf tests. The sysroot download routine is slightly changed, too.
kennytm
added
beta-nominated
|
(highfive disappeared...) |
|
@bors: r+ |
|
📌 Commit 0597bda has been approved by |
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 19, 2017
Make Solaris builder compatible with Solaris 10 retry Unfortunately, rust-lang#45255 does not quite cut it, so use a different approach to have Solaris 10 compatibility by tricking libbacktrace's autoconf tests. The sysroot download routine is slightly changed, too.
bors
added a commit
that referenced
this pull request
Oct 19, 2017
Mark-Simulacrum
added
the
beta-accepted
bors
added a commit
that referenced
this pull request
Oct 23, 2017
[beta] Make Solaris builder compatible with Solaris 10 retry Backport of #45343.
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Oct 24, 2017
[beta] Make Solaris builder compatible with Solaris 10 retry Backport of #45343.
|
The "apt-cache"-based approach introduced in this PR now seems to download >15k packages in CI: https://github.com/rust-lang-ci/rust/actions/runs/4375805054/jobs/7657029939#step:26:2250 |
|
I've put a new approach in #108951. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, #45255 does not quite cut it,
so use a different approach to have Solaris 10 compatibility
by tricking libbacktrace's autoconf tests.
The sysroot download routine is slightly changed, too.