added examples of closures for str::find #45349
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/liballoc/str.rs
Outdated
| /// | ||
| /// ``` | ||
| /// let s = "Löwe 老虎 Léopard"; | ||
| /// | ||
| /// assert_eq!(s.find(char::is_whitespace), Some(5)); | ||
| /// assert_eq!(s.find(char::is_lowercase), Some(1)); | ||
| /// assert_eq!(s.find(|c: char| c.is_whitespace()), Some(5)); | ||
| /// assert_eq!(s.find(|c: char| c.is_lowercase()), Some(1)); |
There was a problem hiding this comment.
Maybe also include a more-complex closure that can't be (easily) written point-free? Strawmen:
assert_eq!(s.find(|c: char| c.is_digit(16)), Some(4));
assert_eq!(s.find(|c: char| c == 'o' || c == 'a', Some(13));
kennytm
added
the
S-waiting-on-review
|
This looks great, thanks so much! @bors: r+ rollup |
|
📌 Commit 2a889eb has been approved by |
kennytm
added
S-waiting-on-bors
…r=steveklabnik added examples of closures for str::find This is an attempt to fix rust-lang#45327 r? @steveklabnik
This is an attempt to fix #45327
r? @steveklabnik