Make Solaris builder compatible with Solaris 10 #45255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
1.22 beta has just been branched off, so we need to explicitly nominate this to beta in order to get this in. |
kennytm
added
the
S-waiting-on-review
|
@bors: r+ Thanks! This seems fine to backport if you'd like, want to send a PR to the beta branch once this lands? |
|
📌 Commit 8f4ff63 has been approved by |
|
Yes. |
kennytm
added
beta-nominated
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 14, 2017
Make Solaris builder compatible with Solaris 10 Would it be possible to get this in the next 1.22.0 beta?
bors
added a commit
that referenced
this pull request
Oct 14, 2017
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 15, 2017
Make Solaris builder compatible with Solaris 10 Would it be possible to get this in the next 1.22.0 beta?
bors
added a commit
that referenced
this pull request
Oct 15, 2017
alexcrichton
added
beta-accepted
bors
added a commit
that referenced
this pull request
Oct 16, 2017
[beta] Make Solaris builder compatible with Solaris 10 Backport of #45255.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 19, 2017
Make Solaris builder compatible with Solaris 10 retry Unfortunately, rust-lang#45255 does not quite cut it, so use a different approach to have Solaris 10 compatibility by tricking libbacktrace's autoconf tests. The sysroot download routine is slightly changed, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be possible to get this in the next 1.22.0 beta?