-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 30 pull requests #35365
Merged
Merged
Rollup of 30 pull requests #35365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginners may try to adapt the tutorial to develop their own code. When using different dependencies, they may use the wildcard for versioning. Since they are new to the language, they will not know that the wildcard asterisk is a string, not a token. Make the correct format more explicit, to remove one potential source of frustration.
This adds a question and answer to the Q&A section of the Copy docs. Specifically, it asks the question I asked while reading the docs, and gives its answer.
Was surprised to learn that heaps were used in this way, then realized upon reading [the linked paper](http://www.cs.cmu.edu/afs/cs/academic/class/15213-f98/doc/dsa.pdf) that it's a totally different type of heap—an important distinction.
…annotation to match other files.
…t, r=jonathandturner E0119 update error format Part of rust-lang#35233, fixes rust-lang#35252 r? @jonathandturner
…turner Update error format for E0062 Fixes rust-lang#35217 as part of rust-lang#35233 There seems to be an issue with the old format ignoring the labels which results in the incorrect line being rendered in the old format. I spoke with @jonathandturner about this and it seems to be a bug. Pertinent information [here](https://gist.github.com/trixnz/ad11e68687529e164427df8f8eb63116). r? @jonathandturner
…andturner Update compiler error E0055 to use new error format Addresses rust-lang#35213, Part of the rust-lang#35233 meta bug r? @jonathandturner
…urner Fix for issue rust-lang#35336 - updating error message for for E0368 to includ… …e a span_label. This fixes rust-lang#35336 as part of rust-lang#35233 r? @jonathandturner
Updated E0391 and E0404 to new error format Fixes rust-lang#35341 and rust-lang#35342 as part of rust-lang#35233. r? @GuillaumeGomez
@bors: r+ p=1 |
📌 Commit cd48161 has been approved by |
@bors: p=1 |
@bors: r- |
@bors: r+ p=1 |
📌 Commit cd48161 has been approved by |
@bors: r+ p=1 |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit cd48161 has been approved by |
@bors: rollup- |
bors
added a commit
that referenced
this pull request
Aug 5, 2016
Rollup of 30 pull requests - Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362 - Failed merges:
💔 Test failed - auto-linux-64-debug-opt |
@bors: retry |
This was referenced Aug 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
range::RangeArgument::{start,end}
. #35041, Add Derive not possible question to Copy #35042, Add doc examples for FileType struct #35076, Add io::Error doc examples #35109, Provide more explicit example of wildcard version in guessing game doc. #35137, A couplestd::net
doc improvements. #35175, Add doc example for Vec #35181, Add doc example forstd::ffi::NulError::nul_position
. #35182, Update the-stack-and-the-heap.md #35189, Docstd::thread::park_timeout
#35239, E0132 update #35264, E0109 Update error format #35266, Clean upstd::raw
docs #35281, Updated E0071 to new format. #35285, E0060 e0061 format update #35289, Update E0079 to new format #35291, Update error message for E0172 #35294, Update error message E0178 #35296, Set label for unreachable pattern #35297, Update error message E0120 #35298, E0110 update error format #35299, Update E0124 to the new error format #35318, Update error format for E0137 #35319, Fix precedence table in reference #35324, E0119 update error format #35326, Update error format for E0062 #35328, Update compiler error E0055 to use new error format #35333, Updated E0391 and E0404 to new error format #35359, Updated error message E0252 #35362