Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0060 needs to be updated to new format #35215

Closed
sophiajt opened this issue Aug 2, 2016 · 4 comments · Fixed by #35289
Closed

E0060 needs to be updated to new format #35215

sophiajt opened this issue Aug 2, 2016 · 4 comments · Fixed by #35289
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0060.rs

Error E0060 needs a span_label, updating it from:

error[E0060]: this function takes at least 1 parameter but 0 parameters were supplied
  --> src/test/compile-fail/E0060.rs:16:14
   |
16 |     unsafe { printf(); } //~ ERROR E0060
   |              ^^^^^^^^
   |
   = note: the following parameter type was expected: *const u8

To:

error[E0060]: this function takes at least 1 parameter but 0 parameters were supplied
  --> src/test/compile-fail/E0060.rs:16:14
   |
16 |     unsafe { printf(); } //~ ERROR E0060
   |              ^^^^^^^^ expected at least 1 parameter
   |
   = note: the following parameter type was expected: *const u8

Bonus: There may be a better way of displaying the information from the note. Could it be part of the label?

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@leikahing
Copy link
Contributor

I will take this issue.

@leikahing
Copy link
Contributor

leikahing commented Aug 4, 2016

@jonathandturner I got my changes in and working, but I had to set an environment variable to see the new formatting style. My command to make sure my changes actually did what they were supposed to looks like this.

RUST_NEW_ERROR_FORMAT=true ./build/x86_64-apple-darwin/stage1/bin/rustc src/test/compile-fail/E0060.rs

Is this expected? If so, I think it would help other new people tackling the issues in #35233 to mention that in your very helpful blog post because I was definitely a little confused when my changes would pass the unit test but output still looked like the old format.

@GuillaumeGomez
Copy link
Member

@birryree: Yes it is. I add it on the issue.

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 4, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 4, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Bonus tracking issue: #35290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants