Add doc examples for range::RangeArgument::{start,end}.

[frewsxcv]

No description provided.

[frewsxcv]

r? @GuillaumeGomez

[GuillaumeGomez]

It doesn't work without putting main function?

[frewsxcv]

extern crate and feature flags here shouldn't be within main, right?

[GuillaumeGomez]

It shouldn't but it works and it is not (the generation is "clever" normally).

[frewsxcv]

It works because rustdoc knows what lines to extract and put them outside main?

[GuillaumeGomez]

Take a look here.

[frewsxcv]

Thanks for the info! Fixed in the latest force push.

[GuillaumeGomez]

---- range::RangeArgument::end_0 stdout ----
    <anon>:9:5: 9:38 error: unresolved import `collections::range::RangeArgument`. Did you mean `self::collections::range`? [E0432]
<anon>:9 use collections::range::RangeArgument;
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:11:18: 11:21 error: no method named `end` found for type `std::ops::RangeFrom<_>` in the current scope 
<anon>:11 assert_eq!((3..).end(), None);
                           ^~~
<anon>:11:1: 11:31 note: in this expansion of assert_eq! (defined in <std macros>)
<anon>:11:18: 11:21 help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it: 
<anon>:11:18: 11:21 help: candidate #1: `use main::collections::range::RangeArgument` 
<anon>:12:20: 12:23 error: no method named `end` found for type `std::ops::Range<_>` in the current scope 
<anon>:12 assert_eq!((3..10).end(), Some(&10));
                             ^~~
<anon>:12:1: 12:38 note: in this expansion of assert_eq! (defined in <std macros>)
<anon>:12:20: 12:23 note: did you mean to write `(3..10).end`? 
<anon>:12 assert_eq!((3..10).end(), Some(&10));
                             ^~~
<anon>:12:1: 12:38 note: in this expansion of assert_eq! (defined in <std macros>)
<anon>:12:20: 12:23 help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it: 
<anon>:12:20: 12:23 help: candidate #1: `use main::collections::range::RangeArgument` 
error: aborting due to previous error(s) 
thread 'range::RangeArgument::end_0' panicked at 'Box<Any>', src/librustc/session/mod.rs:165
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- range::RangeArgument::start_0 stdout ----
    <anon>:9:5: 9:38 error: unresolved import `collections::range::RangeArgument`. Did you mean `self::collections::range`? [E0432]
<anon>:9 use collections::range::RangeArgument;
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:11:19: 11:24 error: no method named `start` found for type `std::ops::RangeTo<_>` in the current scope 
<anon>:11 assert_eq!((..10).start(), None);
                            ^~~~~
<anon>:11:1: 11:34 note: in this expansion of assert_eq! (defined in <std macros>)
<anon>:11:19: 11:24 help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it: 
<anon>:11:19: 11:24 help: candidate #1: `use main::collections::range::RangeArgument` 
<anon>:12:20: 12:25 error: no method named `start` found for type `std::ops::Range<_>` in the current scope 
<anon>:12 assert_eq!((3..10).start(), Some(&3));
                             ^~~~~
<anon>:12:1: 12:39 note: in this expansion of assert_eq! (defined in <std macros>)
<anon>:12:20: 12:25 note: did you mean to write `(3..10).start`? 
<anon>:12 assert_eq!((3..10).start(), Some(&3));
                             ^~~~~
<anon>:12:1: 12:39 note: in this expansion of assert_eq! (defined in <std macros>)
<anon>:12:20: 12:25 help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it: 
<anon>:12:20: 12:25 help: candidate #1: `use main::collections::range::RangeArgument` 
error: aborting due to previous error(s) 
thread 'range::RangeArgument::start_0' panicked at 'Box<Any>', src/librustc/session/mod.rs:165

[frewsxcv]

@GuillaumeGomez Check out the latest commit. It seems to fix the build. Have any idea why? I don't have too much time right now, so I might just squash the commits.

[GuillaumeGomez]

No idea. Certainly because of the "extern crate". However, I'm a bit surprised there is an external import for collections.

[GuillaumeGomez]

The situation of this trait is really strange, however it's used in std stable code so let's merge it. Thanks!

@bors: r+ rollup

[bors]

📌 Commit 727d929 has been approved by GuillaumeGomez

[bors]

⌛ Testing commit 727d929 with merge 1329da6...

[bors]

💔 Test failed - auto-win-msvc-64-opt-no-mir

[alexcrichton]

@bors: retry

• mk: Only pass -Zorbit=off in stage1/2 #35187

On Tue, Aug 2, 2016 at 12:09 PM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt-no-mir
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-no-mir/builds/1

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35041 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95NPckCnUsRSvkbZRjnLCpkXxtcCCks5qb5X-gaJpZM4JUwIq
.