mir: validate `Move` call arguments are locals or box derefs by rabindra789 · Pull Request #160651 · rust-lang/rust

rabindra789 · 2026-08-06T18:01:48Z

This PR adds a MIR validation check for Move arguments passed to Call and TailCall terminators.
A moved argument should be either a local or the contents of the Box. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with -Zvalidate-mir, using the same phase restriction as the existing Copy check.
Added a regression test covering the invalid case.

rustbot · 2026-08-06T18:01:52Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

rustbot · 2026-08-06T18:01:54Z

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 18 candidates

oli-obk · 2026-08-07T10:07:17Z

r? @WaffleLapkin

rustbot · 2026-08-07T10:07:21Z

WaffleLapkin is not on the review rotation at the moment.
They may take a while to respond.

WaffleLapkin

@bors r+

View changes since this review

rust-bors · 2026-08-26T17:32:37Z

📌 Commit 1154159 has been approved by WaffleLapkin

It is now in the queue for this repository.

…call-args, r=WaffleLapkin mir: validate `Move` call arguments are locals or box derefs Fixes rust-lang#103362. This PR adds a MIR validation check for `Move` arguments passed to `Call` and `TailCall` terminators. A moved argument should be either a local or the contents of the `Box`. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with `-Zvalidate-mir`, using the same phase restriction as the existing `Copy` check. Added a regression test covering the invalid case.

…uwer Rollup of 4 pull requests Successful merges: - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161736 (Tidy: show todo reason when lint fails (and fix the lint's tidy allow statement which was weird and broken...)) - #161052 (Add regression test for generic inference) - #161818 (Fix long type on diagnostics for conditionally implemented traits)

…r=WaffleLapkin mir: validate `Move` call arguments are locals or box derefs Fixes #103362. This PR adds a MIR validation check for `Move` arguments passed to `Call` and `TailCall` terminators. A moved argument should be either a local or the contents of the `Box`. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with `-Zvalidate-mir`, using the same phase restriction as the existing `Copy` check. Added a regression test covering the invalid case.

rustbot · 2026-08-27T14:58:23Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rabindra789 · 2026-08-31T02:48:14Z

@rustbot review

WaffleLapkin · 2026-09-04T17:03:34Z

@bors try jobs=x86_64-gnu-tools

…r=<try> mir: validate `Move` call arguments are locals or box derefs try-job: x86_64-gnu-tools

rust-bors · 2026-09-04T18:01:23Z

☀️ Try build successful (CI)
Build commit: a8661e7 (a8661e725bbbea354f1a138aa033aeb4fdc17490)
Base parent: 0ed41eb (0ed41eb4142dda2df61eb1145a312c1a9d62eb56)

WaffleLapkin

@bors r+

looks like the rollup failure was unrelated to this PR... fun.

View changes since this review

rust-bors · 2026-09-08T09:26:50Z

📌 Commit 98f4067 has been approved by WaffleLapkin

It is now in the queue for this repository.

…call-args, r=WaffleLapkin mir: validate `Move` call arguments are locals or box derefs Fixes rust-lang#103362. This PR adds a MIR validation check for `Move` arguments passed to `Call` and `TailCall` terminators. A moved argument should be either a local or the contents of the `Box`. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with `-Zvalidate-mir`, using the same phase restriction as the existing `Copy` check. Added a regression test covering the invalid case.

…uwer Rollup of 8 pull requests Successful merges: - #160505 (delegation: supporting inherent impls) - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`) - #161912 (run `extern "tail"` with `byval` argument test) - #162435 (windows-gnu: document libgcc requirement) - #162439 (Update books) - #162459 (docs(time): replace "method" with "function") - #162465 (Fix my duplicate thanks entry)

…call-args, r=WaffleLapkin mir: validate `Move` call arguments are locals or box derefs Fixes rust-lang#103362. This PR adds a MIR validation check for `Move` arguments passed to `Call` and `TailCall` terminators. A moved argument should be either a local or the contents of the `Box`. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with `-Zvalidate-mir`, using the same phase restriction as the existing `Copy` check. Added a regression test covering the invalid case.

…uwer Rollup of 10 pull requests Successful merges: - #162470 (Subtree sync for rustc_codegen_cranelift) - #160505 (delegation: supporting inherent impls) - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`) - #161912 (run `extern "tail"` with `byval` argument test) - #162435 (windows-gnu: document libgcc requirement) - #162439 (Update books) - #162451 (Add regression test for item-local diagnostic attribute lint levels) - #162459 (docs(time): replace "method" with "function") - #162465 (Fix my duplicate thanks entry)

…call-args, r=WaffleLapkin mir: validate `Move` call arguments are locals or box derefs Fixes rust-lang#103362. This PR adds a MIR validation check for `Move` arguments passed to `Call` and `TailCall` terminators. A moved argument should be either a local or the contents of the `Box`. Other places can deinitialize memory that codegen does not track correctly. The check is only enabled with `-Zvalidate-mir`, using the same phase restriction as the existing `Copy` check. Added a regression test covering the invalid case.

…uwer Rollup of 9 pull requests Successful merges: - #160505 (delegation: supporting inherent impls) - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`) - #161912 (run `extern "tail"` with `byval` argument test) - #162435 (windows-gnu: document libgcc requirement) - #162439 (Update books) - #162451 (Add regression test for item-local diagnostic attribute lint levels) - #162459 (docs(time): replace "method" with "function") - #162465 (Fix my duplicate thanks entry)

rust-bors · 2026-09-08T12:23:59Z

The bors config at rust-bors.toml is invalid in this PR. Parse error:

TOML parse error at line 87, column 5
   |
87 |     "arm64ami" = "latest-gha-runner-ami-arm64"
   |     ^
missing comma between key-value pairs, expected `,`

…uwer Rollup of 9 pull requests Successful merges: - #160505 (delegation: supporting inherent impls) - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`) - #161912 (run `extern "tail"` with `byval` argument test) - #162435 (windows-gnu: document libgcc requirement) - #162439 (Update books) - #162451 (Add regression test for item-local diagnostic attribute lint levels) - #162459 (docs(time): replace "method" with "function") - #162465 (Fix my duplicate thanks entry)

theemathas · 2026-09-08T13:07:34Z

Asked about the above error at https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Invalid.20rust-bors.2Etoml.20error/with/622534709

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2026

rustbot assigned mati865 Aug 6, 2026

rabindra789 marked this pull request as draft August 6, 2026 18:27

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026

rabindra789 force-pushed the fix/mir-verifier-move-call-args branch from 6cf4605 to 1154159 Compare August 7, 2026 06:08

rabindra789 marked this pull request as ready for review August 7, 2026 06:17

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2026

rustbot assigned WaffleLapkin Aug 7, 2026

rustbot unassigned mati865 Aug 7, 2026

This comment was marked as resolved.

Sign in to view

theemathas mentioned this pull request Aug 16, 2026

mir: accept ambiguous unsize coercion validation results #161156

Open

WaffleLapkin approved these changes Aug 26, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2026

JonathanBrouwer mentioned this pull request Aug 26, 2026

Rollup of 4 pull requests #161829

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2026

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026

Auto merge of #160651 - rabindra789:fix/mir-verifier-move-call-args, …

a8661e7

…r=<try> mir: validate `Move` call arguments are locals or box derefs try-job: x86_64-gnu-tools

WaffleLapkin approved these changes Sep 8, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026

JonathanBrouwer mentioned this pull request Sep 8, 2026

Rollup of 6 pull requests #162464

Closed

JonathanBrouwer mentioned this pull request Sep 8, 2026

Rollup of 8 pull requests #162466

Closed

JonathanBrouwer mentioned this pull request Sep 8, 2026

Rollup of 10 pull requests #162472

Closed

JonathanBrouwer mentioned this pull request Sep 8, 2026

Rollup of 9 pull requests #162474

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 8, 2026

Uh oh!

Uh oh!

Conversation

rabindra789 commented Aug 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 6, 2026

Uh oh!

rustbot commented Aug 6, 2026

Uh oh!

oli-obk commented Aug 7, 2026

Uh oh!

rustbot commented Aug 7, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

WaffleLapkin left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 26, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 27, 2026

Uh oh!

rabindra789 commented Aug 31, 2026

Uh oh!

WaffleLapkin commented Sep 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 4, 2026

Uh oh!

WaffleLapkin left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

rust-bors Bot commented Sep 8, 2026

Uh oh!

theemathas commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rabindra789 commented Aug 6, 2026 •

edited by rustbot

Loading

WaffleLapkin left a comment •

edited by rustbot

Loading

WaffleLapkin left a comment •

edited by rustbot

Loading