Tidy: show todo reason when lint fails (and fix the lint's tidy allow statement which was weird and broken...)

[jdonszelmann]

r? @WaffleLapkin

Note

I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

[rustbot]

WaffleLapkin is currently at their maximum review capacity.
They may take a while to respond.

[jdonszelmann]

the tidy TODO lint previously implemented ignoring themselves, rather stupidly. And it worked different than all other tidy ignores, and had to be on the same line, instead of a previous line. With this lint using the standard ignore system now, the ignore comment needs to go the the previous line.

View changes since the review

[WaffleLapkin]

r=me with nits (I don't think having TODO: <no message> is useful, just omit this part if there is no message)

View changes since this review

[jdonszelmann]

@bors r=wafflelapkin

[rust-bors]

📌 Commit 5d9f9e7 has been approved by wafflelapkin

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: wafflelapkin
Duration: 2h 53m 41s
Pushing bff8e12 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3b8ee6c (parent) -> bff8e12 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bff8e12ff5e6bcd53dfb1dbccdcec80a60a856ed --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-gnu-llvm-22-1: 49m 24s -> 1h 14m (+50.4%)
2. x86_64-rust-for-linux: 38m 5s -> 53m 44s (+41.1%)
3. x86_64-gnu-gcc-core-tests: 7m 57s -> 10m 47s (+35.6%)
4. x86_64-gnu-nopt: 1h 51m -> 2h 30m (+35.1%)
5. dist-arm-linux-gnueabi: 1h 31m -> 59m 41s (-35.1%)
6. x86_64-gnu-llvm-21-1: 57m 45s -> 38m 9s (-33.9%)
7. dist-i686-msvc: 2h 8m -> 1h 25m (-33.5%)
8. arm-android: 1h 15m -> 1h 39m (+32.8%)
9. test-various: 1h 33m -> 2h 4m (+32.3%)
10. x86_64-gnu-stable: 1h 54m -> 2h 30m (+31.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (bff8e12): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 9.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	9.5%	[9.5%, 9.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	9.5%	[9.5%, 9.5%]	1

Cycles

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	4
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	4
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	4

Bootstrap: 473.778s -> 474.868s (0.23%)
Artifact size: 402.59 MiB -> 402.61 MiB (0.00%)