Skip to content

Add regression test for item-local diagnostic attribute lint levels - #162451

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-135772-local-diagnostic-attribute-lint
Sep 8, 2026
Merged

Add regression test for item-local diagnostic attribute lint levels#162451
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-135772-local-diagnostic-attribute-lint

Conversation

@chenyukang

@chenyukang chenyukang commented Sep 8, 2026

Copy link
Copy Markdown
Member

Closes #135772

This issue was fixed by #160499 indirectly.

r? @mejrs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 8, 2026
@mejrs

mejrs commented Sep 8, 2026

Copy link
Copy Markdown
Member

Oh interesting, what in that PR made it fixed? 🤔

@mejrs mejrs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7768834 has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026
@chenyukang

Copy link
Copy Markdown
Member Author

Oh interesting, what in that PR made it fixed? 🤔

I guess that PR moved the lint from resolver to attribute parsing and reuse the existing item-local lint check mechanism.

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
…-diagnostic-attribute-lint, r=mejrs

Add regression test for item-local diagnostic attribute lint levels

Closes rust-lang#135772

This issue was fixed by rust-lang#160499 indirectly.

r? @mejrs
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #162470 (Subtree sync for rustc_codegen_cranelift)
 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
…-diagnostic-attribute-lint, r=mejrs

Add regression test for item-local diagnostic attribute lint levels

Closes rust-lang#135772

This issue was fixed by rust-lang#160499 indirectly.

r? @mejrs
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #162462 (Fix unsoundness in `VecDeque::from_iter(vec::IntoIter)`)
 - #162468 (mir_build: Rename `lower_let_expr` to `lower_fallible_let`, and clarify)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #161932 (Only check `#[allow(dead_code)]` on the trait)
 - #162236 (Call renumberMetadataForAssembly() in LLVMRustPrintModule())
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162455 (Update codegen-llvm/inline-debuginfo.rs for distinct DILocation)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
@rust-bors
rust-bors Bot merged commit a84ac06 into rust-lang:main Sep 8, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
Rollup merge of #162451 - chenyukang:yukang-fix-135772-local-diagnostic-attribute-lint, r=mejrs

Add regression test for item-local diagnostic attribute lint levels

Closes #135772

This issue was fixed by #160499 indirectly.

r? @mejrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow attribute does not surpress unknown_or_malformed_diagnostic_attributes

3 participants