`#[cfg]`: suggest alternative `target_` name when the value does not match by scrabsha · Pull Request #154777 · rust-lang/rust

scrabsha · 2026-04-03T19:21:22Z

View all comments

Renders as:

scrabsha · 2026-04-04T19:05:18Z

r? jdonszelmann

rustbot · 2026-04-04T19:05:22Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-04-04T19:05:29Z

Some changes occurred in check-cfg diagnostics

cc @Urgau

Urgau

This is a great start! Left some comments.

View changes since this review

compiler/rustc_lint/src/early/diagnostics/check_cfg.rs

compiler/rustc_lint/src/lints.rs

compiler/rustc_target/src/lib.rs

tests/ui/cfg/suggest-alternative-name-on-target.rs

compiler/rustc_lint/src/lints.rs

tests/ui/cfg/suggest-alternative-name-on-target.rs

compiler/rustc_lint/src/early/diagnostics/check_cfg.rs

jdonszelmann · 2026-04-05T10:17:17Z

@rustbot author

Thanks @Urgau for helping with the review! Do you want to look at it again before I review & merge it or can I finish it if your comments are addressed and my own are addressed too?

rustbot · 2026-04-05T10:17:22Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-04-05T10:47:10Z

Some changes occurred in cfg and check-cfg configuration

cc @Urgau

Urgau

Left a nit picks.

View changes since this review

compiler/rustc_lint/src/early/diagnostics/check_cfg.rs

compiler/rustc_lint/src/lints.rs

compiler/rustc_lint/src/early/diagnostics/check_cfg.rs

Urgau · 2026-04-05T13:08:30Z

Do you want to look at it again before I review & merge it or can I finish it if your comments are addressed and my own are addressed too?

I did another quick review. Feel free to do our review after that.

Urgau

Looks good to me (module the two nits). I will let @jdonszelmann do a final review.

View changes since this review

compiler/rustc_lint/src/early/diagnostics/check_cfg.rs

squash me in @-

…match

scrabsha · 2026-04-05T16:52:52Z

@Urgau thank you for your reviews!

jdonszelmann

@bors r+ rollup

View changes since this review

rust-bors · 2026-04-06T06:17:26Z

📌 Commit 1d79216 has been approved by jdonszelmann

It is now in the queue for this repository.

…szelmann `#[cfg]`: suggest alternative `target_` name when the value does not match

…uwer Rollup of 9 pull requests Successful merges: - #153440 (Various LTO cleanups) - #151899 (Constify fold, reduce and last for iterator) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154777 (`#[cfg]`: suggest alternative `target_` name when the value does not match) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)

Rollup merge of #154777 - scrabsha:push-nunzyzrqlwqw, r=jdonszelmann `#[cfg]`: suggest alternative `target_` name when the value does not match

scrabsha · 2026-04-06T14:06:25Z

update on this: flakiness is being addressed in #154886 :/

…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#153440 (Various LTO cleanups) - rust-lang/rust#151899 (Constify fold, reduce and last for iterator) - rust-lang/rust#154561 (Suggest similar keyword when visibility is not followed by an item) - rust-lang/rust#154657 (Fix pattern assignment suggestions for uninitialized bindings) - rust-lang/rust#154717 (Fix ICE in unsafe binder discriminant helpers) - rust-lang/rust#154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - rust-lang/rust#154777 (`#[cfg]`: suggest alternative `target_` name when the value does not match) - rust-lang/rust#154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - rust-lang/rust#154850 (ast_validation: scalable vectors okay for rustdoc)

…JonathanBrouwer Stabilize check-cfg suggestions for symbol When I was working on rust-lang#154794, I found a weird CI fail rust-lang#154794 (comment), I finally found this caused by unstable cfg suggestions by using `FxHashSet`(from PR rust-lang#154777). Because my PR by luck insert a new symbol, which makes the final diagnostic order changed. It's a standalone issue, so it's better to fix in a separate PR.

Rollup merge of #154886 - chenyukang:yukang-fix-cfg-sugg, r=JonathanBrouwer Stabilize check-cfg suggestions for symbol When I was working on #154794, I found a weird CI fail #154794 (comment), I finally found this caused by unstable cfg suggestions by using `FxHashSet`(from PR #154777). Because my PR by luck insert a new symbol, which makes the final diagnostic order changed. It's a standalone issue, so it's better to fix in a separate PR.

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2026

This comment has been minimized.

Sign in to view

scrabsha force-pushed the push-nunzyzrqlwqw branch from d47248a to bf4bc77 Compare April 3, 2026 21:03

This comment has been minimized.

Sign in to view

scrabsha force-pushed the push-nunzyzrqlwqw branch from bf4bc77 to ca0a5e8 Compare April 3, 2026 21:40

This comment has been minimized.

Sign in to view

scrabsha force-pushed the push-nunzyzrqlwqw branch 2 times, most recently from db9d9a7 to 96fc8a8 Compare April 4, 2026 16:57

This comment has been minimized.

Sign in to view

scrabsha force-pushed the push-nunzyzrqlwqw branch from 96fc8a8 to 0a12c07 Compare April 4, 2026 17:27

scrabsha changed the title ~~Suggest another target_ cfg name when the value does not match the original name~~ #[cfg]: suggest alternative target_ name when the value does not match Apr 4, 2026

scrabsha force-pushed the push-nunzyzrqlwqw branch from 0a12c07 to 813eef5 Compare April 4, 2026 17:34

rustbot assigned jdonszelmann Apr 4, 2026

scrabsha marked this pull request as ready for review April 4, 2026 19:05

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 4, 2026

Urgau reviewed Apr 4, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026

scrabsha force-pushed the push-nunzyzrqlwqw branch from 813eef5 to ccad9da Compare April 5, 2026 10:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2026

Urgau reviewed Apr 5, 2026

View reviewed changes

scrabsha force-pushed the push-nunzyzrqlwqw branch 2 times, most recently from 275aa0d to 8a11d99 Compare April 5, 2026 15:15

Urgau approved these changes Apr 5, 2026

View reviewed changes

compiler/rustc_lint/src/early/diagnostics/check_cfg.rs Show resolved Hide resolved

scrabsha added 2 commits April 5, 2026 16:47

#[cfg]: add test for "target_ value is used for another target_"

e84576a

squash me in @-

#[cfg]: suggest alternative target_ name when the value does not …

1d79216

…match

scrabsha force-pushed the push-nunzyzrqlwqw branch from 8a11d99 to 1d79216 Compare April 5, 2026 16:52

jdonszelmann reviewed Apr 6, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 6, 2026

Rollup merge of rust-lang#154777 - scrabsha:push-nunzyzrqlwqw, r=jdon…

f02d31c

…szelmann `#[cfg]`: suggest alternative `target_` name when the value does not match

This was referenced Apr 6, 2026

Rollup of 7 pull requests #154869

Closed

Rollup of 9 pull requests #154870

Merged

rust-bors bot merged commit cbe9c4d into rust-lang:main Apr 6, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Apr 6, 2026

rust-timer added a commit that referenced this pull request Apr 6, 2026

Unrolled build for #154777

09fd169

Rollup merge of #154777 - scrabsha:push-nunzyzrqlwqw, r=jdonszelmann `#[cfg]`: suggest alternative `target_` name when the value does not match

scrabsha deleted the push-nunzyzrqlwqw branch April 6, 2026 10:32

chenyukang mentioned this pull request Apr 6, 2026

Stabilize check-cfg suggestions for symbol #154886

Merged

Uh oh!

Conversation

scrabsha commented Apr 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

scrabsha commented Apr 4, 2026

Uh oh!

rustbot commented Apr 4, 2026

Uh oh!

rustbot commented Apr 4, 2026

Uh oh!

Urgau left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdonszelmann commented Apr 5, 2026

Uh oh!

rustbot commented Apr 5, 2026

Uh oh!

rustbot commented Apr 5, 2026

Uh oh!

Urgau left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Urgau commented Apr 5, 2026

Uh oh!

Urgau left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scrabsha commented Apr 5, 2026

Uh oh!

jdonszelmann left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors bot commented Apr 6, 2026

Uh oh!

Uh oh!

scrabsha commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

scrabsha commented Apr 3, 2026 •

edited by rustbot

Loading

Urgau left a comment •

edited by rustbot

Loading

Urgau left a comment •

edited by rustbot

Loading

Urgau left a comment •

edited by rustbot

Loading

jdonszelmann left a comment •

edited by rustbot

Loading