Rollup of 6 pull requests#154740
Merged
rust-bors[bot] merged 19 commits intorust-lang:mainfrom Apr 3, 2026
Merged
Conversation
This implementation was added recently in f12288e ("TryFrom<integer> for bool") but used an old feature gate and stabilization version. Update to reflect when these were actually added.
…egative ones
rustdoc assumed every `Deref` impl has an associated `Target` type,
but negative impls (e.g. `impl !Deref for T {}`) have none.
Skip them in both the trait-impl collection pass and the
HTML render pass to avoid panicking on the missing Target.
This functions name totally contradicted what it did. And the only places it was used immediatly `!`ed it. Push the `!` into the function, and rename it to make sense. Should hopefully result in less head-scratching next time someone looks at this.
rustdoc ICE fix: When collecting `Deref` impls with their targets, skip the negative ones
rustdoc assumed every `Deref` impl has an associated `Target` type, but negative impls (e.g. `impl !Deref for T {}`) have none.
Skip them in both the trait-impl collection pass and the HTML render pass to avoid panicking on the missing `Target`.
Closes rust-lang#128801.
…szelmann Make #[cfg] suggest any or all on #[cfg(a, b)]
core: Update the feature gate on `TryFrom<integer> for bool` This implementation was added recently in f12288e ("TryFrom<integer> for bool") but used an old feature gate and stabilization version. Update to reflect when these were actually added.
…, r=GuillaumeGomez rustdoc: fix href of extern crates in search results To avoid modifying the search index, I instead overloaded an existing field that is always unused for extern crate items. fixes rust-lang#148300 r? @GuillaumeGomez
… r=GuillaumeGomez rustdoc: Improve internal function name This functions name totally contradicted what it did. And the only places it was used immediatly `!`ed it. Push the `!` into the function, and rename it to make sense. Should hopefully result in less head-scratching next time someone looks at this. r? @GuillaumeGomez
fix(std): avoid AT_MINSIGSTKSZ on uclibc targets Closes rust-lang#154679 `AT_MINSIGSTKSZ` is not defined on uclibc. r? @tgross35
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 55e86c9968 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 55e86c9 (parent) -> 5bbdeaa (this PR) Test differencesShow 10 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 5bbdeaa9a8dc563185f40e99f96704cbcc7a6e6e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (5bbdeaa): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.0%, secondary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.6%, secondary 14.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 486.952s -> 485.659s (-0.27%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Derefimpls with their targets, skip the negative ones #154444 (rustdoc ICE fix: When collectingDerefimpls with their targets, skip the negative ones)TryFrom<integer> for bool#154691 (core: Update the feature gate onTryFrom<integer> for bool)Failed merges:
ill_formed_attribute_inputwith better help message #154722 (fix(lints): Improveill_formed_attribute_inputwith better help message)r? @ghost
Create a similar rollup