Skip to content

Make #[cfg] suggest any or all on #[cfg(a, b)]#154590

Open
scrabsha wants to merge 5 commits intorust-lang:mainfrom
scrabsha:push-xzmtpsntoxwm
Open

Make #[cfg] suggest any or all on #[cfg(a, b)]#154590
scrabsha wants to merge 5 commits intorust-lang:mainfrom
scrabsha:push-xzmtpsntoxwm

Conversation

@scrabsha
Copy link
Copy Markdown
Contributor

@scrabsha scrabsha commented Mar 30, 2026 •
edited
Loading

Renders as:
out

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 30, 2026
@scrabsha scrabsha changed the title Push xzmtpsntoxwm Make #[cfg] suggest any or all on #[cfg(a, b)] Mar 30, 2026
jyn514
jyn514 reviewed Mar 30, 2026
View reviewed changes
@scrabsha scrabsha force-pushed the push-xzmtpsntoxwm branch from 2bdf88d to 17052c7 Compare March 30, 2026 14:20
scrabsha
scrabsha commented Mar 30, 2026
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@scrabsha scrabsha force-pushed the push-xzmtpsntoxwm branch from 17052c7 to 93db6f1 Compare April 1, 2026 20:59
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scrabsha scrabsha force-pushed the push-xzmtpsntoxwm branch from 93db6f1 to 4f81621 Compare April 2, 2026 07:12
@scrabsha scrabsha force-pushed the push-xzmtpsntoxwm branch from 4f81621 to 843178c Compare April 2, 2026 11:19
@scrabsha
Copy link
Copy Markdown
Contributor Author

scrabsha commented Apr 2, 2026

r? jdonszelmann

@scrabsha scrabsha marked this pull request as ready for review April 2, 2026 11:20
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

jdonszelmann
jdonszelmann reviewed Apr 2, 2026
View reviewed changes
jdonszelmann
jdonszelmann reviewed Apr 2, 2026
View reviewed changes
jdonszelmann
jdonszelmann reviewed Apr 2, 2026
View reviewed changes
compiler/rustc_expand/src/expand.rs Outdated
ForeignItemKind::TyAlias(_) => Target::ForeignTy,
ForeignItemKind::MacCall(_) => {
// Turned into another kind of foreign item during macro expansion.
unreachable!();
Copy link
Copy Markdown
Contributor

@jdonszelmann jdonszelmann Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one worries me, since when we expand cfg, these items very much still exist

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 2, 2026
@scrabsha scrabsha force-pushed the push-xzmtpsntoxwm branch 2 times, most recently from e827017 to 61e10b7 Compare April 2, 2026 14:05
@scrabsha scrabsha force-pushed the push-xzmtpsntoxwm branch from 61e10b7 to 11394c0 Compare April 2, 2026 14:16
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scrabsha scrabsha force-pushed the push-xzmtpsntoxwm branch from 11394c0 to edb9322 Compare April 2, 2026 14:54
@scrabsha
Copy link
Copy Markdown
Contributor Author

scrabsha commented Apr 2, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2026
@jdonszelmann
Copy link
Copy Markdown
Contributor

jdonszelmann commented Apr 2, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 2, 2026

📌 Commit edb9322 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154590 - scrabsha:push-xzmtpsntoxwm, r=jdon…
77b3736 
…szelmann

Make #[cfg] suggest any or all on #[cfg(a, b)]
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 2, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Apr 2, 2026
@bors
Auto merge of #154726 - JonathanBrouwer:rollup-PfGSgjF, r=JonathanBro…
7bbdaf5 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #154444 (rustdoc ICE fix: When collecting `Deref` impls with their targets, skip the negative ones)
 - #154590 (Make #[cfg] suggest any or all on #[cfg(a, b)])
 - #154691 (core: Update the feature gate on `TryFrom<integer> for bool`)
 - #154697 (rustdoc: fix href of extern crates in search results)

Failed merges:

 - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdonszelmann jdonszelmann jdonszelmann requested changes

+1 more reviewer

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@scrabsha @rust-log-analyzer @rustbot @jdonszelmann @jyn514 @adwinwhite