Split AttributeParserError Diagnostic implementation into subfunctions#154580
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Mar 31, 2026
Merged
Split AttributeParserError Diagnostic implementation into subfunctions#154580rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-uzvmzwlqvqzr
branch
from
8614c1a to
542f697
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-uzvmzwlqvqzr
branch
from
542f697 to
77e5234
Compare
Contributor
Author
|
r? jdonszelmann |
Collaborator
|
|
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
jdonszelmann
requested changes
Mar 30, 2026
tests/ui/conditional-compilation/cfg-attr-syntax-validation.stderr
Outdated
Show resolved
Hide resolved
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
scrabsha
force-pushed
the
push-uzvmzwlqvqzr
branch
from
77e5234 to
bb40df6
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 31, 2026
…szelmann Split AttributeParserError Diagnostic implementation into subfunctions
This was referenced Mar 31, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
…uwer Rollup of 12 pull requests Successful merges: - #154419 (Take first task group for further execution) - #154569 (Fix type alias where clause suggestion spacing issue) - #154617 (Update flate2 users to use zlib-rs) - #154618 (Fix AtomicPtr::update's cfg gate) - #154620 (stabilize new Range type and iterator) - #151932 (refactor: remove `Adjust::ReborrowPin`) - #153980 (refactor: move doc(rust_logo) check to parser) - #154134 (fix: guard paren-sugar pretty-printing on short trait args) - #154270 (Create `Ty` type alias in `rustc_type_ir`) - #154580 (Split AttributeParserError Diagnostic implementation into subfunctions) - #154606 (misc test cleanups) - #154612 (Add a test for a now fixed ICE with `offset_of!()`)
rust-timer
added a commit
that referenced
this pull request
Mar 31, 2026
Rollup merge of #154580 - scrabsha:push-uzvmzwlqvqzr, r=jdonszelmann Split AttributeParserError Diagnostic implementation into subfunctions
github-actions bot
pushed a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Mar 31, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#154419 (Take first task group for further execution) - rust-lang/rust#154569 (Fix type alias where clause suggestion spacing issue) - rust-lang/rust#154617 (Update flate2 users to use zlib-rs) - rust-lang/rust#154618 (Fix AtomicPtr::update's cfg gate) - rust-lang/rust#154620 (stabilize new Range type and iterator) - rust-lang/rust#151932 (refactor: remove `Adjust::ReborrowPin`) - rust-lang/rust#153980 (refactor: move doc(rust_logo) check to parser) - rust-lang/rust#154134 (fix: guard paren-sugar pretty-printing on short trait args) - rust-lang/rust#154270 (Create `Ty` type alias in `rustc_type_ir`) - rust-lang/rust#154580 (Split AttributeParserError Diagnostic implementation into subfunctions) - rust-lang/rust#154606 (misc test cleanups) - rust-lang/rust#154612 (Add a test for a now fixed ICE with `offset_of!()`)
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Apr 1, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#154419 (Take first task group for further execution) - rust-lang/rust#154569 (Fix type alias where clause suggestion spacing issue) - rust-lang/rust#154617 (Update flate2 users to use zlib-rs) - rust-lang/rust#154618 (Fix AtomicPtr::update's cfg gate) - rust-lang/rust#154620 (stabilize new Range type and iterator) - rust-lang/rust#151932 (refactor: remove `Adjust::ReborrowPin`) - rust-lang/rust#153980 (refactor: move doc(rust_logo) check to parser) - rust-lang/rust#154134 (fix: guard paren-sugar pretty-printing on short trait args) - rust-lang/rust#154270 (Create `Ty` type alias in `rustc_type_ir`) - rust-lang/rust#154580 (Split AttributeParserError Diagnostic implementation into subfunctions) - rust-lang/rust#154606 (misc test cleanups) - rust-lang/rust#154612 (Add a test for a now fixed ICE with `offset_of!()`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second commit alters the oracles a bit. I tried to blame the initial code to figure out why
ExpectedStringLiteralwas special cased but couldn't find anything. I think it is ok to remove this special case.