Skip to content

refactor: move doc(rust_logo) check to parser#153980

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
mehdiakiki:pr-check_attrs-rust_logo
Mar 31, 2026
Merged

refactor: move doc(rust_logo) check to parser#153980
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
mehdiakiki:pr-check_attrs-rust_logo

Conversation

@mehdiakiki
Copy link
Copy Markdown
Contributor

@mehdiakiki mehdiakiki commented Mar 17, 2026

Reducing check_attr.rs size by moving the #[doc(rust_logo)] feature gate into DocParser.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 17, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Mar 17, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 17, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 14 candidates

jdonszelmann
jdonszelmann reviewed Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jdonszelmann jdonszelmann left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

View changes since this review

compiler/rustc_attr_parsing/src/attributes/doc.rs Outdated
Some(sym::fake_variadic) => no_args_and_not_crate_level!(fake_variadic),
Some(sym::search_unbox) => no_args_and_not_crate_level!(search_unbox),
Some(sym::rust_logo) => no_args_and_crate_level!(rust_logo),
Some(sym::rust_logo) => {
Copy link
Copy Markdown
Contributor

@jdonszelmann jdonszelmann Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool if we could somehow keep using these macros, otherwise you gotta write it out every time

Copy link
Copy Markdown
Contributor Author

@mehdiakiki mehdiakiki Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do later today!

@jdonszelmann
Copy link
Copy Markdown
Contributor

jdonszelmann commented Mar 17, 2026

r? me

@rustbot rustbot assigned jdonszelmann and unassigned JohnTitor Mar 17, 2026
@jdonszelmann
Copy link
Copy Markdown
Contributor

jdonszelmann commented Mar 17, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 17, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@mehdiakiki
Copy link
Copy Markdown
Contributor Author

mehdiakiki commented Mar 19, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2026
jdonszelmann
jdonszelmann approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jdonszelmann jdonszelmann left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 30, 2026

📌 Commit 48987fd has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2026
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 30, 2026
@tgross35
Rollup merge of rust-lang#153980 - mehdiakiki:pr-check_attrs-rust_log…
f5f76ab 
…o, r=jdonszelmann

refactor: move doc(rust_logo) check to parser

Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.
@tgross35 tgross35 mentioned this pull request Mar 30, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154611 - tgross35:rollup-I9ve7BM, r=tgross35
d60aa38 
Rollup of 7 pull requests

Successful merges:

 - #142659 (compiler-builtins: Clean up features)
 - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
 - #153648 (Fix EII function aliases eliminated by LTO)
 - #153790 (Fix regression when dealing with generics/values with unresolved inference)
 - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error)
 - #153980 (refactor: move doc(rust_logo) check to parser)
 - #154551 (Skip suggestions pointing to macro def for assert_eq)
rust-bors bot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154611 - tgross35:rollup-I9ve7BM, r=tgross35
35ee928 
Rollup of 7 pull requests

Successful merges:

 - #142659 (compiler-builtins: Clean up features)
 - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
 - #153648 (Fix EII function aliases eliminated by LTO)
 - #153790 (Fix regression when dealing with generics/values with unresolved inference)
 - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error)
 - #153980 (refactor: move doc(rust_logo) check to parser)
 - #154551 (Skip suggestions pointing to macro def for assert_eq)
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 31, 2026
@tgross35
Rollup merge of rust-lang#153980 - mehdiakiki:pr-check_attrs-rust_log…
c2884f2 
…o, r=jdonszelmann

refactor: move doc(rust_logo) check to parser

Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.
@tgross35 tgross35 mentioned this pull request Mar 31, 2026
Closed
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 31, 2026
@tgross35
Rollup merge of rust-lang#153980 - mehdiakiki:pr-check_attrs-rust_log…
15e4952 
…o, r=jdonszelmann

refactor: move doc(rust_logo) check to parser

Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.
@tgross35 tgross35 mentioned this pull request Mar 31, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 31, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153980 - mehdiakiki:pr-check_attrs-rust_log…
6a7fef5 
…o, r=jdonszelmann

refactor: move doc(rust_logo) check to parser

Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.
This was referenced Mar 31, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154637 - JonathanBrouwer:rollup-fGsU36o, r=JonathanBro…
0e95a0f 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #154419 (Take first task group for further execution)
 - #154569 (Fix  type alias where clause suggestion spacing issue)
 - #154617 (Update flate2 users to use zlib-rs)
 - #154618 (Fix AtomicPtr::update's cfg gate)
 - #154620 (stabilize new Range type and iterator)
 - #151932 (refactor: remove `Adjust::ReborrowPin`)
 - #153980 (refactor: move doc(rust_logo) check to parser)
 - #154134 (fix: guard paren-sugar pretty-printing on short trait args)
 - #154270 (Create `Ty` type alias in `rustc_type_ir`)
 - #154580 (Split AttributeParserError Diagnostic implementation into subfunctions)
 - #154606 (misc test cleanups)
 - #154612 (Add a test for a now fixed ICE with `offset_of!()`)
@rust-bors rust-bors bot merged commit bfffbb6 into rust-lang:main Mar 31, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 31, 2026
rust-timer added a commit that referenced this pull request Mar 31, 2026
@rust-timer
Unrolled build for #153980
63e48ed 
Rollup merge of #153980 - mehdiakiki:pr-check_attrs-rust_logo, r=jdonszelmann

refactor: move doc(rust_logo) check to parser

Reducing `check_attr.rs` size by moving the `#[doc(rust_logo)]` feature gate into `DocParser`.
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154637 - JonathanBrouwer:rollup-fGsU36o, r=JonathanBro…
84dcb0e 
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#154419 (Take first task group for further execution)
 - rust-lang/rust#154569 (Fix  type alias where clause suggestion spacing issue)
 - rust-lang/rust#154617 (Update flate2 users to use zlib-rs)
 - rust-lang/rust#154618 (Fix AtomicPtr::update's cfg gate)
 - rust-lang/rust#154620 (stabilize new Range type and iterator)
 - rust-lang/rust#151932 (refactor: remove `Adjust::ReborrowPin`)
 - rust-lang/rust#153980 (refactor: move doc(rust_logo) check to parser)
 - rust-lang/rust#154134 (fix: guard paren-sugar pretty-printing on short trait args)
 - rust-lang/rust#154270 (Create `Ty` type alias in `rustc_type_ir`)
 - rust-lang/rust#154580 (Split AttributeParserError Diagnostic implementation into subfunctions)
 - rust-lang/rust#154606 (misc test cleanups)
 - rust-lang/rust#154612 (Add a test for a now fixed ICE with `offset_of!()`)
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Apr 1, 2026
@bors
Auto merge of #154637 - JonathanBrouwer:rollup-fGsU36o, r=JonathanBro…
fd5759d 
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#154419 (Take first task group for further execution)
 - rust-lang/rust#154569 (Fix  type alias where clause suggestion spacing issue)
 - rust-lang/rust#154617 (Update flate2 users to use zlib-rs)
 - rust-lang/rust#154618 (Fix AtomicPtr::update's cfg gate)
 - rust-lang/rust#154620 (stabilize new Range type and iterator)
 - rust-lang/rust#151932 (refactor: remove `Adjust::ReborrowPin`)
 - rust-lang/rust#153980 (refactor: move doc(rust_logo) check to parser)
 - rust-lang/rust#154134 (fix: guard paren-sugar pretty-printing on short trait args)
 - rust-lang/rust#154270 (Create `Ty` type alias in `rustc_type_ir`)
 - rust-lang/rust#154580 (Split AttributeParserError Diagnostic implementation into subfunctions)
 - rust-lang/rust#154606 (misc test cleanups)
 - rust-lang/rust#154612 (Add a test for a now fixed ICE with `offset_of!()`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdonszelmann jdonszelmann jdonszelmann approved these changes

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mehdiakiki @rustbot @jdonszelmann @JohnTitor