Fix regression when dealing with generics/values with unresolved inference#153790
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 31, 2026
Merged
Conversation
…smute_obligation_for_reporting`
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Mar 30, 2026
…r=jdonszelmann Fix regression when dealing with generics/values with unresolved inference Follow up for rust-lang#151703, fixing regression caused in rollup rust-lang#152825 Forgot to handle generics & unresolved inference variables (as in `get_safe_transmute_error_and_reason`) in my previous PR. This followup checks for them before trying to normalize. I am not completely sure its right approach to have this check cloned but as `select_transmute_obligation_for_reporting` fn just chooses obligation and doesn't actually return an error, this check shouldn't be removed from `get_safe_transmute_error_and_reasnon`. If there is any better solution, let me kmow. Fixes: rust-lang#153755 r? @jdonszelmann
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
Rollup of 7 pull requests Successful merges: - #142659 (compiler-builtins: Clean up features) - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - #153648 (Fix EII function aliases eliminated by LTO) - #153790 (Fix regression when dealing with generics/values with unresolved inference) - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error) - #153980 (refactor: move doc(rust_logo) check to parser) - #154551 (Skip suggestions pointing to macro def for assert_eq)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
Rollup of 7 pull requests Successful merges: - #142659 (compiler-builtins: Clean up features) - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - #153648 (Fix EII function aliases eliminated by LTO) - #153790 (Fix regression when dealing with generics/values with unresolved inference) - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error) - #153980 (refactor: move doc(rust_logo) check to parser) - #154551 (Skip suggestions pointing to macro def for assert_eq)
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Mar 31, 2026
…r=jdonszelmann Fix regression when dealing with generics/values with unresolved inference Follow up for rust-lang#151703, fixing regression caused in rollup rust-lang#152825 Forgot to handle generics & unresolved inference variables (as in `get_safe_transmute_error_and_reason`) in my previous PR. This followup checks for them before trying to normalize. I am not completely sure its right approach to have this check cloned but as `select_transmute_obligation_for_reporting` fn just chooses obligation and doesn't actually return an error, this check shouldn't be removed from `get_safe_transmute_error_and_reasnon`. If there is any better solution, let me kmow. Fixes: rust-lang#153755 r? @jdonszelmann
Contributor
|
I think this may be related to #154625 (comment)? |
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#154625), which was unapproved. |
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
Fix regression when dealing with generics/values with unresolved inference try-job: aarch64-gnu-llvm-21-1
This comment has been minimized.
This comment has been minimized.
Contributor
Contributor
|
Sorry about that, guess it's not this one @bors r=jdonszelmann |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
Rollup of 9 pull requests Successful merges: - #154582 (miri subtree update) - #142659 (compiler-builtins: Clean up features) - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - #153648 (Fix EII function aliases eliminated by LTO) - #153790 (Fix regression when dealing with generics/values with unresolved inference) - #154551 (Skip suggestions pointing to macro def for assert_eq) - #154574 (delete several `ui/consts` tests) - #154577 (Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename) - #154579 (remove debug requirement from hooks)
rust-timer
added a commit
that referenced
this pull request
Mar 31, 2026
Rollup merge of #153790 - zedddie:transmutation-regression, r=jdonszelmann Fix regression when dealing with generics/values with unresolved inference Follow up for #151703, fixing regression caused in rollup #152825 Forgot to handle generics & unresolved inference variables (as in `get_safe_transmute_error_and_reason`) in my previous PR. This followup checks for them before trying to normalize. I am not completely sure its right approach to have this check cloned but as `select_transmute_obligation_for_reporting` fn just chooses obligation and doesn't actually return an error, this check shouldn't be removed from `get_safe_transmute_error_and_reasnon`. If there is any better solution, let me kmow. Fixes: #153755 r? @jdonszelmann
github-actions bot
pushed a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Mar 31, 2026
Rollup of 9 pull requests Successful merges: - rust-lang/rust#154582 (miri subtree update) - rust-lang/rust#142659 (compiler-builtins: Clean up features) - rust-lang/rust#153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - rust-lang/rust#153648 (Fix EII function aliases eliminated by LTO) - rust-lang/rust#153790 (Fix regression when dealing with generics/values with unresolved inference) - rust-lang/rust#154551 (Skip suggestions pointing to macro def for assert_eq) - rust-lang/rust#154574 (delete several `ui/consts` tests) - rust-lang/rust#154577 (Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename) - rust-lang/rust#154579 (remove debug requirement from hooks)
chenyukang
pushed a commit
to chenyukang/rust
that referenced
this pull request
Apr 1, 2026
Rollup of 9 pull requests Successful merges: - rust-lang#154582 (miri subtree update) - rust-lang#142659 (compiler-builtins: Clean up features) - rust-lang#153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - rust-lang#153648 (Fix EII function aliases eliminated by LTO) - rust-lang#153790 (Fix regression when dealing with generics/values with unresolved inference) - rust-lang#154551 (Skip suggestions pointing to macro def for assert_eq) - rust-lang#154574 (delete several `ui/consts` tests) - rust-lang#154577 (Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename) - rust-lang#154579 (remove debug requirement from hooks)
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Apr 1, 2026
Rollup of 9 pull requests Successful merges: - rust-lang/rust#154582 (miri subtree update) - rust-lang/rust#142659 (compiler-builtins: Clean up features) - rust-lang/rust#153574 (Avoid ICE when param-env normalization leaves unresolved inference variables) - rust-lang/rust#153648 (Fix EII function aliases eliminated by LTO) - rust-lang/rust#153790 (Fix regression when dealing with generics/values with unresolved inference) - rust-lang/rust#154551 (Skip suggestions pointing to macro def for assert_eq) - rust-lang/rust#154574 (delete several `ui/consts` tests) - rust-lang/rust#154577 (Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename) - rust-lang/rust#154579 (remove debug requirement from hooks)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #151703, fixing regression caused in rollup #152825
Forgot to handle generics & unresolved inference variables (as in
get_safe_transmute_error_and_reason) in my previous PR. This followup checks for them before trying to normalize.I am not completely sure its right approach to have this check cloned but as
select_transmute_obligation_for_reportingfn just chooses obligation and doesn't actually return an error, this check shouldn't be removed fromget_safe_transmute_error_and_reasnon. If there is any better solution, let me kmow.Fixes: #153755
r? @jdonszelmann