Skip to content

Migration of LintDiagnostic - part 6#153352

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag
Mar 4, 2026
Merged

Migration of LintDiagnostic - part 6#153352
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag

Conversation

@GuillaumeGomez
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 3, 2026
@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 3, 2026
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
Migration of `LintDiagnostic` - part 6
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 3, 2026

☀️ Try build successful (CI)
Build commit: 876b6ef (876b6ef1bf89f46d14b37355b05340fff2f21e48, parent: d2218f5f5ca3f502772ec4cb69fc2ee44e096512)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (876b6ef): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.1%, 0.4%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 5.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.5% [5.2%, 5.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.0% [3.6%, 6.6%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.344s -> 480.38s (-0.20%)
Artifact size: 397.04 MiB -> 394.98 MiB (-0.52%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 3, 2026
@JonathanBrouwer
Copy link
Contributor

Perf is just noise.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026
@JonathanBrouwer
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 3, 2026

📌 Commit 56d636a has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
…athanBrouwer

Migration of `LintDiagnostic` - part 6

Part of rust-lang#153099.

r? @JonathanBrouwer
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #153280 (Add regression test for `doc(fake_variadic)` on reexports)
 - #153358 (Boundary tests for various Duration-float operations)
 - #153272 (Add `Path::absolute` method as alias for `std::path::absolute`)
 - #153295 (update panicking() docs for panic=abort)
 - #153352 (Migration of `LintDiagnostic` - part 6)
rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026
Rollup of 8 pull requests

Successful merges:

 - #153280 (Add regression test for `doc(fake_variadic)` on reexports)
 - #153302 (x86: reserve `bl` and `bh` registers to match `rbx`)
 - #153358 (Boundary tests for various Duration-float operations)
 - #153048 (Improve irrefutable let-else lint wording)
 - #153258 (diag: Suppress `.clone()` suggestion inside derive macro expansions)
 - #153272 (Add `Path::absolute` method as alias for `std::path::absolute`)
 - #153295 (update panicking() docs for panic=abort)
 - #153352 (Migration of `LintDiagnostic` - part 6)
@rust-bors rust-bors bot merged commit c4f239e into rust-lang:main Mar 4, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Mar 4, 2026
Rollup merge of #153352 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer

Migration of `LintDiagnostic` - part 6

Part of #153099.

r? @JonathanBrouwer
@rustbot rustbot added this to the 1.96.0 milestone Mar 4, 2026
@GuillaumeGomez GuillaumeGomez deleted the migrate-diag branch March 4, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants