x86: reserve bl and bh registers to match rbx#153302
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 4, 2026
Merged
x86: reserve bl and bh registers to match rbx#153302rust-bors[bot] merged 1 commit intorust-lang:mainfrom
bl and bh registers to match rbx#153302rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
r? @Amanieu |
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
Rollup of 8 pull requests Successful merges: - #153280 (Add regression test for `doc(fake_variadic)` on reexports) - #153302 (x86: reserve `bl` and `bh` registers to match `rbx`) - #153358 (Boundary tests for various Duration-float operations) - #153048 (Improve irrefutable let-else lint wording) - #153258 (diag: Suppress `.clone()` suggestion inside derive macro expansions) - #153272 (Add `Path::absolute` method as alias for `std::path::absolute`) - #153295 (update panicking() docs for panic=abort) - #153352 (Migration of `LintDiagnostic` - part 6)
rust-timer
added a commit
that referenced
this pull request
Mar 4, 2026
Rollup merge of #153302 - CathalMullan:rbx, r=Amanieu x86: reserve `bl` and `bh` registers to match `rbx` `bl` and `bh` need to be explicitly marked as reserved, as they are sub-registers of `rbx`, which is reserved by LLVM. Discovered this while trying to run Graviola through Cranelift, which was becoming corrupted due to the register allocator assigning `bl`: rust-lang/rustc_codegen_cranelift#1629 cc: @bjorn3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blandbhneed to be explicitly marked as reserved, as they are sub-registers ofrbx, which is reserved by LLVM.Discovered this while trying to run Graviola through Cranelift, which was becoming corrupted due to the register allocator assigning
bl: rust-lang/rustc_codegen_cranelift#1629cc: @bjorn3