Add regression test for doc(fake_variadic) on reexports#153280
Open
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
Open
Add regression test for doc(fake_variadic) on reexports#153280GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
doc(fake_variadic) on reexports#153280GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
Thanks! @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
…r=lolbinarycat Add regression test for `doc(fake_variadic)` on reexports Follow-up of rust-lang#153136. Out of the four doc attributes remaining to be tested (`fake_variadic`, `keyword`, `attribute` and `notable_trait`), only `fake_variadic` could have been impacted by reexports: * `attribute` and `keyword` are not supposed to be reexported (they're supposed to be used on private modules) * `notable_trait` is applied to a trait, so whether it's reexported or not, it still works. r? @lolbinarycat
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
…uwer Rollup of 5 pull requests Successful merges: - #153280 (Add regression test for `doc(fake_variadic)` on reexports) - #153358 (Boundary tests for various Duration-float operations) - #153272 (Add `Path::absolute` method as alias for `std::path::absolute`) - #153295 (update panicking() docs for panic=abort) - #153352 (Migration of `LintDiagnostic` - part 6)
Contributor
|
⌛ Testing commit ae8890f with merge 8019f1f... Workflow: https://github.com/rust-lang/rust/actions/runs/22649269407 |
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
Add regression test for `doc(fake_variadic)` on reexports Follow-up of #153136. Out of the four doc attributes remaining to be tested (`fake_variadic`, `keyword`, `attribute` and `notable_trait`), only `fake_variadic` could have been impacted by reexports: * `attribute` and `keyword` are not supposed to be reexported (they're supposed to be used on private modules) * `notable_trait` is applied to a trait, so whether it's reexported or not, it still works. r? @lolbinarycat
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Mar 4, 2026
…r=lolbinarycat Add regression test for `doc(fake_variadic)` on reexports Follow-up of rust-lang#153136. Out of the four doc attributes remaining to be tested (`fake_variadic`, `keyword`, `attribute` and `notable_trait`), only `fake_variadic` could have been impacted by reexports: * `attribute` and `keyword` are not supposed to be reexported (they're supposed to be used on private modules) * `notable_trait` is applied to a trait, so whether it's reexported or not, it still works. r? @lolbinarycat
Member
|
@bors yield (to enclosing rollup) |
Contributor
|
Auto build cancelled. Cancelled workflows: The next pull request likely to be tested is #153377. |
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
Rollup of 8 pull requests Successful merges: - #153280 (Add regression test for `doc(fake_variadic)` on reexports) - #153302 (x86: reserve `bl` and `bh` registers to match `rbx`) - #153358 (Boundary tests for various Duration-float operations) - #153048 (Improve irrefutable let-else lint wording) - #153258 (diag: Suppress `.clone()` suggestion inside derive macro expansions) - #153272 (Add `Path::absolute` method as alias for `std::path::absolute`) - #153295 (update panicking() docs for panic=abort) - #153352 (Migration of `LintDiagnostic` - part 6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #153136. Out of the four doc attributes remaining to be tested (
fake_variadic,keyword,attributeandnotable_trait), onlyfake_variadiccould have been impacted by reexports:attributeandkeywordare not supposed to be reexported (they're supposed to be used on private modules)notable_traitis applied to a trait, so whether it's reexported or not, it still works.r? @lolbinarycat