Recover feature lang_items for emscripten#153128
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 28, 2026
Merged
Recover feature lang_items for emscripten#153128rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 26, 2026
…oboet Recover feature lang_items for emscripten Fixes rust-lang#152469 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 27, 2026
…oboet Recover feature lang_items for emscripten Fixes rust-lang#152469 (comment)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
Rollup of 7 pull requests Successful merges: - #151143 (explicit tail calls: support indirect arguments) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #150828 (Improved security section in rustdoc for `current_exe`) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 27, 2026
…oboet Recover feature lang_items for emscripten Fixes rust-lang#152469 (comment)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 27, 2026
…oboet Recover feature lang_items for emscripten Fixes rust-lang#152469 (comment)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…uwer Rollup of 11 pull requests Successful merges: - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #153179 (Force a CI LLVM stamp bump) - #150828 (Improved security section in rustdoc for `current_exe`) - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate) - #152674 (rustc_public: remove the `CrateDefItems` trait) - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
This was referenced Feb 27, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…uwer Rollup of 12 pull requests Successful merges: - #151143 (explicit tail calls: support indirect arguments) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #153175 (Clarify a confusing green-path function) - #153179 (Force a CI LLVM stamp bump) - #150828 (Improved security section in rustdoc for `current_exe`) - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate) - #152674 (rustc_public: remove the `CrateDefItems` trait) - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…uwer Rollup of 12 pull requests Successful merges: - #151143 (explicit tail calls: support indirect arguments) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #153175 (Clarify a confusing green-path function) - #153179 (Force a CI LLVM stamp bump) - #150828 (Improved security section in rustdoc for `current_exe`) - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate) - #152674 (rustc_public: remove the `CrateDefItems` trait) - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
rust-timer
added a commit
that referenced
this pull request
Feb 28, 2026
Rollup merge of #153128 - mu001999-contrib:fix/features, r=joboet Recover feature lang_items for emscripten Fixes #152469 (comment)
kleisauke
reviewed
Mar 1, 2026
| #![no_std] | ||
| #![unstable(feature = "panic_unwind", issue = "32837")] | ||
| #![doc(issue_tracker_base_url = "https://github.com/rust-lang/rust/issues/")] | ||
| #![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), lang_items)] |
Contributor
There was a problem hiding this comment.
This should probably be:
Suggested change
| #![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), lang_items)] | |
| #![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), feature(lang_items))] |
(untested)
See:
error: cannot find attribute `lang_items` in this scope
--> /rustc/38c0de8dcb14d42290042521be9958d37f3fa390/library/panic_unwind/src/lib.rs:17:69
|
17 | #![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), lang_items)]
| ^^^^^^^^^^
error[E0658]: lang items are subject to change
--> /rustc/38c0de8dcb14d42290042521be9958d37f3fa390/library/panic_unwind/src/emcc.rs:40:1
|
40 | #[lang = "eh_catch_typeinfo"]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: add `#![feature(lang_items)]` to the crate attributes to enable
= note: this compiler was built on 2026-02-28; consider upgrading it if it is out of date
For more information about this error, try `rustc --explain E0658`.
error: could not compile `panic_unwind` (lib) due to 2 previous errors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 1, 2026
…oboet Recover feature lang_items for emscripten Fixes rust-lang#152469 (comment) The previous rust-lang#153128 lacks of `feature`
rust-timer
added a commit
that referenced
this pull request
Mar 1, 2026
Rollup merge of #153255 - mu001999-contrib:fix/features, r=joboet Recover feature lang_items for emscripten Fixes #152469 (comment) The previous #153128 lacks of `feature`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152469 (comment)