Skip to content

rustc_public: remove the CrateDefItems trait#152674

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
makai410:rpub/sus-trait
Feb 28, 2026
Merged

rustc_public: remove the CrateDefItems trait#152674
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
makai410:rpub/sus-trait

Conversation

@makai410
Copy link
Member

@makai410 makai410 commented Feb 15, 2026

This trait feels sus since its documentation says it's for 'retrieving all items from a definition' however it only provides an associated_items method (??), which I believe should only be valid for impls and traits.

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2026

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2026

r? @celinval

rustbot has assigned @celinval.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: project-stable-mir
  • project-stable-mir expanded to celinval, makai410, oli-obk, scottmcm
  • Random selection from celinval, scottmcm

celinval
celinval approved these changes Feb 27, 2026
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 27, 2026

📌 Commit 945caf3 has been approved by celinval

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 27, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152674 - makai410:rpub/sus-trait, r=celinval
36fe953 
rustc_public: remove the `CrateDefItems` trait

This trait feels sus since its documentation says it's for 'retrieving all items from a definition' however it only provides an `associated_items` method (??), which I believe should only be valid for `impl`s and `trait`s.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 27, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 27, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152674 - makai410:rpub/sus-trait, r=celinval
6d163b7 
rustc_public: remove the `CrateDefItems` trait

This trait feels sus since its documentation says it's for 'retrieving all items from a definition' however it only provides an `associated_items` method (??), which I believe should only be valid for `impl`s and `trait`s.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 27, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 27, 2026
@bors
Auto merge of #153180 - JonathanBrouwer:rollup-5vxerGq, r=JonathanBro…
c4aa863 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.)
 - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`)
 - #153179 (Force a CI LLVM stamp bump)
 - #150828 (Improved security section in rustdoc for `current_exe`)
 - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate)
 - #152674 (rustc_public: remove the `CrateDefItems` trait)
 - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead)
 - #153117 (Remove mutation from macro path URL construction)
 - #153128 (Recover feature lang_items for emscripten)
 - #153138 (Print path root when printing path)
 - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 27, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152674 - makai410:rpub/sus-trait, r=celinval
04b39a7 
rustc_public: remove the `CrateDefItems` trait

This trait feels sus since its documentation says it's for 'retrieving all items from a definition' however it only provides an `associated_items` method (??), which I believe should only be valid for `impl`s and `trait`s.
This was referenced Feb 27, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 27, 2026
@bors
Auto merge of #153183 - JonathanBrouwer:rollup-APFHc2s, r=JonathanBro…
83ad207 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #151143 (explicit tail calls: support indirect arguments)
 - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`)
 - #153175 (Clarify a confusing green-path function)
 - #153179 (Force a CI LLVM stamp bump)
 - #150828 (Improved security section in rustdoc for `current_exe`)
 - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate)
 - #152674 (rustc_public: remove the `CrateDefItems` trait)
 - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead)
 - #153117 (Remove mutation from macro path URL construction)
 - #153128 (Recover feature lang_items for emscripten)
 - #153138 (Print path root when printing path)
 - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
rust-bors bot pushed a commit that referenced this pull request Feb 27, 2026
@bors
Auto merge of #153183 - JonathanBrouwer:rollup-APFHc2s, r=JonathanBro…
67aec36 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #151143 (explicit tail calls: support indirect arguments)
 - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`)
 - #153175 (Clarify a confusing green-path function)
 - #153179 (Force a CI LLVM stamp bump)
 - #150828 (Improved security section in rustdoc for `current_exe`)
 - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate)
 - #152674 (rustc_public: remove the `CrateDefItems` trait)
 - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead)
 - #153117 (Remove mutation from macro path URL construction)
 - #153128 (Recover feature lang_items for emscripten)
 - #153138 (Print path root when printing path)
 - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
@rust-bors rust-bors bot merged commit b2099ac into rust-lang:main Feb 28, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 28, 2026
rust-timer added a commit that referenced this pull request Feb 28, 2026
@rust-timer
Unrolled build for #152674
e84d5bf 
Rollup merge of #152674 - makai410:rpub/sus-trait, r=celinval

rustc_public: remove the `CrateDefItems` trait

This trait feels sus since its documentation says it's for 'retrieving all items from a definition' however it only provides an `associated_items` method (??), which I believe should only be valid for `impl`s and `trait`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celinval celinval celinval approved these changes

Assignees

@celinval celinval

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@makai410 @rustbot @celinval