Remove mutation from macro path URL construction by arferreira · Pull Request #153117 · rust-lang/rust

arferreira · 2026-02-26T03:43:42Z

Resolves the FIXME in generate_macro_def_id_path.
The old code mutated path to build the URL — popping the macro name, pushing an interned filename, then restoring the original at the end. None of that was necessary. A slice pattern gives us module_path and last without touching the original, and push_fmt(format_args!(...)) writes the filename directly into the URL builder, same as make_href already does.
Also tightened the error guards: the original path.len() < 2 is now two distinct checks with messages that describe the actual failure (empty path vs. single-element path missing the crate prefix).

r? @GuillaumeGomez

…f_id_path

GuillaumeGomez · 2026-02-26T10:44:46Z

Thanks! Curious if there is any impact on perf, let's check.

@bors try @rust-timer queue

Remove mutation from macro path URL construction

rust-bors · 2026-02-26T12:55:54Z

☀️ Try build successful (CI)
Build commit: fe881b0 (fe881b0e815ddccf4a1110ba7f7526d2ecda09f2, parent: f02672cb8bffef88934d31d9044257a4d11e5d1f)

rust-timer · 2026-02-26T13:40:27Z

Finished benchmarking commit (fe881b0): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.7%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[1.1%, 7.3%]	3
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-2.1%	[-2.2%, -2.0%]	2
All ❌✅ (primary)	-2.7%	[-2.7%, -2.7%]	1

Cycles

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[2.7%, 4.4%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.407s -> 486.994s (1.58%)
Artifact size: 395.80 MiB -> 397.80 MiB (0.50%)

GuillaumeGomez · 2026-02-26T14:30:23Z

No impact on perf, just cleaner code. All good!

@bors r+ rollup

rust-bors · 2026-02-26T14:30:26Z

📌 Commit a226650 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@GuillaumeGomez

…, r=GuillaumeGomez Remove mutation from macro path URL construction Resolves the `FIXME` in `generate_macro_def_id_path`. The old code mutated `path` to build the URL — popping the macro name, pushing an interned filename, then restoring the original at the end. None of that was necessary. A slice pattern gives us `module_path` and `last` without touching the original, and `push_fmt(format_args!(...))` writes the filename directly into the URL builder, same as `make_href` already does. Also tightened the error guards: the original `path.len() < 2` is now two distinct checks with messages that describe the actual failure (empty path vs. single-element path missing the crate prefix). r? @GuillaumeGomez

@GuillaumeGomez

…, r=GuillaumeGomez Remove mutation from macro path URL construction Resolves the `FIXME` in `generate_macro_def_id_path`. The old code mutated `path` to build the URL — popping the macro name, pushing an interned filename, then restoring the original at the end. None of that was necessary. A slice pattern gives us `module_path` and `last` without touching the original, and `push_fmt(format_args!(...))` writes the filename directly into the URL builder, same as `make_href` already does. Also tightened the error guards: the original `path.len() < 2` is now two distinct checks with messages that describe the actual failure (empty path vs. single-element path missing the crate prefix). r? @GuillaumeGomez

Rollup of 7 pull requests Successful merges: - #151143 (explicit tail calls: support indirect arguments) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #150828 (Improved security section in rustdoc for `current_exe`) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)

@GuillaumeGomez

…, r=GuillaumeGomez Remove mutation from macro path URL construction Resolves the `FIXME` in `generate_macro_def_id_path`. The old code mutated `path` to build the URL — popping the macro name, pushing an interned filename, then restoring the original at the end. None of that was necessary. A slice pattern gives us `module_path` and `last` without touching the original, and `push_fmt(format_args!(...))` writes the filename directly into the URL builder, same as `make_href` already does. Also tightened the error guards: the original `path.len() < 2` is now two distinct checks with messages that describe the actual failure (empty path vs. single-element path missing the crate prefix). r? @GuillaumeGomez

@GuillaumeGomez

…, r=GuillaumeGomez Remove mutation from macro path URL construction Resolves the `FIXME` in `generate_macro_def_id_path`. The old code mutated `path` to build the URL — popping the macro name, pushing an interned filename, then restoring the original at the end. None of that was necessary. A slice pattern gives us `module_path` and `last` without touching the original, and `push_fmt(format_args!(...))` writes the filename directly into the URL builder, same as `make_href` already does. Also tightened the error guards: the original `path.len() < 2` is now two distinct checks with messages that describe the actual failure (empty path vs. single-element path missing the crate prefix). r? @GuillaumeGomez

…uwer Rollup of 11 pull requests Successful merges: - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #153179 (Force a CI LLVM stamp bump) - #150828 (Improved security section in rustdoc for `current_exe`) - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate) - #152674 (rustc_public: remove the `CrateDefItems` trait) - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)

@GuillaumeGomez

…, r=GuillaumeGomez Remove mutation from macro path URL construction Resolves the `FIXME` in `generate_macro_def_id_path`. The old code mutated `path` to build the URL — popping the macro name, pushing an interned filename, then restoring the original at the end. None of that was necessary. A slice pattern gives us `module_path` and `last` without touching the original, and `push_fmt(format_args!(...))` writes the filename directly into the URL builder, same as `make_href` already does. Also tightened the error guards: the original `path.len() < 2` is now two distinct checks with messages that describe the actual failure (empty path vs. single-element path missing the crate prefix). r? @GuillaumeGomez

…uwer Rollup of 12 pull requests Successful merges: - #151143 (explicit tail calls: support indirect arguments) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #153175 (Clarify a confusing green-path function) - #153179 (Force a CI LLVM stamp bump) - #150828 (Improved security section in rustdoc for `current_exe`) - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate) - #152674 (rustc_public: remove the `CrateDefItems` trait) - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)

@GuillaumeGomez

Rollup merge of #153117 - arferreira:cleanup-macro-path-iter, r=GuillaumeGomez Remove mutation from macro path URL construction Resolves the `FIXME` in `generate_macro_def_id_path`. The old code mutated `path` to build the URL — popping the macro name, pushing an interned filename, then restoring the original at the end. None of that was necessary. A slice pattern gives us `module_path` and `last` without touching the original, and `push_fmt(format_args!(...))` writes the filename directly into the URL builder, same as `make_href` already does. Also tightened the error guards: the original `path.len() < 2` is now two distinct checks with messages that describe the actual failure (empty path vs. single-element path missing the crate prefix). r? @GuillaumeGomez

Remove mutation from macro path URL construction in generate_macro_de…

a226650

…f_id_path

rustbot assigned GuillaumeGomez Feb 26, 2026

GuillaumeGomez approved these changes Feb 26, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Feb 26, 2026

Auto merge of #153117 - arferreira:cleanup-macro-path-iter, r=<try>

fe881b0

Remove mutation from macro path URL construction

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2026

JonathanBrouwer mentioned this pull request Feb 26, 2026

Rollup of 5 pull requests #153137

Closed

matthiaskrgr mentioned this pull request Feb 27, 2026

Rollup of 7 pull requests #153167

Closed

JonathanBrouwer mentioned this pull request Feb 27, 2026

Rollup of 10 pull requests #153171

Closed

JonathanBrouwer mentioned this pull request Feb 27, 2026

Rollup of 11 pull requests #153180

Closed

This was referenced Feb 27, 2026

Rollup of 12 pull requests #153182

Closed

Rollup of 12 pull requests #153183

Merged

rust-bors bot merged commit 57fe4c0 into rust-lang:main Feb 28, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove mutation from macro path URL construction#153117

Remove mutation from macro path URL construction#153117
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
arferreira:cleanup-macro-path-iter

arferreira commented Feb 26, 2026

Uh oh!

GuillaumeGomez commented Feb 26, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Feb 26, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 26, 2026

Uh oh!

GuillaumeGomez commented Feb 26, 2026

Uh oh!

rust-bors bot commented Feb 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

arferreira commented Feb 26, 2026

Uh oh!

GuillaumeGomez commented Feb 26, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Feb 26, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 26, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

GuillaumeGomez commented Feb 26, 2026

Uh oh!

rust-bors bot commented Feb 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants