Rollup of 12 pull requests #151794
Merged
Rollup of 12 pull requests #151794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was used to gate `f16` and `f128` when support across
backends and targets was inconsistent. We now have the rustc builtin cfg
`target_has_reliable{f16,f128}` which has taken over this usecase.
Remove no-f16-f128 since it is now unused and redundant.
This simplifies the `PlaceholderReachability` `enum` by replacing the case when no placeholders were reached with a standard `Option::None`. It also rewrites the API for `scc::Annotations` to be update-mut rather than a more Functional programming style. This showed some slight performance impact in early tests of the PR and definitely makes the implementation simpler.
Avoid `unsafe fn` in remaining x86 tests
…tation Adds documentation for `stdarch-gen-arm`
- Adds vluti2 intrinsics - Adds famin/famax intrinsics - Adds vstl1(q) intrinsics - Adds vldap1(q) intrinsics - Excludes vldap1_lane_f64 as in testing it fails assert_intr. There seems to be some bad IR gen from rust. - Adds vscale(q) intrinsics - Adds new intrinsics to arm_intrinsics.json - Had to be done manually as intrinsics are not yet on developer.arm.com
Moves the relevant defintions from the aarch64 yaml to the arm_shared.
The opcodes for these intructions are not recognised by the dissasembler on the windows msvc toolchain. As such they are not translated to the relevant mneumonic and the `assert_instr` test fails. Please see [failing test](https://github.com/rust-lang/stdarch/actions/runs/20992978794/job/60342796821?pr=1994#logs).
…sing-intrinsics Adds missing neon intrinsics
This makes cdylibs compile to working Emscripten dynamic libraries without passing extra RUSTFLAGS. This was previously approved as PR 98358 but there were CI failures that I never got around to fixing.
Signed-off-by: Usman Akinyemi <[email protected]>
remove fp16 target feature from some vreinterpret intrinsics
resolve: Mark items under exported ambiguous imports as exported After rust-lang#147984 one of the imports in an ambiguous import set becomes accessible under a deny-by-default deprecation lint. So if it points to something, that something needs to be marked as exported, so its MIR is encoded into metadata, its symbol is not lost from object files, etc. The added test shows an example. This fixes around 10-20 crater regressions found in rust-lang#149195 (comment). Unblocks rust-lang#149195.
Do not suggest `derive` if there is already an impl This PR fixes an issue where the compiler would suggest adding `#[derive(Trait)]` even if the struct or enum already implements that trait manually. Fixes [rust-lang#146515](rust-lang#146515)
…nieu
compiler-builtins: Remove the no-f16-f128 feature
This option was used to gate `f16` and `f128` when support across backends and targets was inconsistent. We now have the rustc builtin cfg `target_has_reliable{f16,f128}` which has taken over this usecase. Remove no-f16-f128 since it is now unused and redundant.
…bank [RFC] rustc_parse: improve the error diagnostic for "missing let in let chain"
…t, r=tgross35 Bump `std`'s `backtrace`'s `rustc-demangle` Alternative to rust-lang#151659. Fixes rust-lang#151548.
…te, r=lcnr Borrowck: Simplify SCC annotation computation, placeholder rewriting This change backports some changes from the now abandoned rust-lang#142623. Notably, it simplifies the `PlaceholderReachability` `enum` by replacing the case when no placeholders were reached with a standard `Option::None`. It also rewrites the API for `scc::Annotations` to be update-mut rather than a more Functional programming style. This showed some slight performance impact in early tests of the PR and definitely makes the implementation simpler. This probably wants a perf run just for good measure. r? @lcnr
Remove Fuchsia from target OS list in unix.rs for sleep Fuchsia doesn't support clock_nanosleep so default back to using nanosleep
…boet fix undefined behavior in VecDeque::splice closes rust-lang#151758
…, r=folkertdev stdarch subtree update Subtree update of `stdarch` to rust-lang/stdarch@9040e2f. Created using https://github.com/rust-lang/josh-sync. r? @ghost
…-151411, r=lolbinarycat [rustdoc] Add regression test for rust-lang#151411 Fixes rust-lang#151411. Seems like the ICE was already solved by rust-lang#151255. Well in any case, more regression tests won't hurt. r? @lolbinarycat
… r=oli-obk clean up checks for constant promotion of integer division/remainder operations I found the old logic with matches on `Option`s returned by other matches to be kind of complicated, so I rewrote it with `let` chains. There should be no change in behavior.
rustbot
added
A-compiler-builtins
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing de6d33c (parent) -> ba284f4 (this PR) Test differencesShow 32 test diffsStage 1
Stage 2
Additionally, 24 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ba284f468cd2cda48420251efc991758ec13d450 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (ba284f4): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.4%, secondary -5.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.844s -> 475.861s (0.21%) |
Contributor
Author
|
Looks like noise. |
rustbot
added
the
perf-regression-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
deriveif there is already an impl #150720 (Do not suggestderiveif there is already an impl)std'sbacktrace'srustc-demangle#151660 (Bumpstd'sbacktrace'srustc-demangle)set_output_kindfor Emscripten linker #151704 (Implementset_output_kindfor Emscripten linker)r? @ghost
Create a similar rollup