Skip to content

Bump std's backtrace's rustc-demangle #151660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fmease wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump std's backtrace's rustc-demangle #151660

fmease wants to merge 1 commit into from
+3 −3

Conversation

@fmease
Copy link
Member

@fmease fmease commented Jan 25, 2026 •
edited by rustbot
Loading

Alternative to #151659.

Fixes #151548.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 25, 2026
@fmease fmease changed the title Bump std's' backtrace's rustc-demangle' Bump std's backtrace's rustc-demangle' Jan 25, 2026
@fmease fmease force-pushed the bump-backtrace-demangler-alt branch from 850c30f to 59c0e13 Compare January 25, 2026 23:09
@fmease
Copy link
Member Author

fmease commented Jan 25, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
@bors
Auto merge of #151660 - fmease:bump-backtrace-demangler-alt, r=<try>
cc1e3a0 
Bump `std`'s `backtrace`'s `rustc-demangle`'
@fmease fmease changed the title Bump std's backtrace's rustc-demangle' Bump std's backtrace's rustc-demangle Jan 25, 2026
@fmease fmease force-pushed the bump-backtrace-demangler-alt branch from 59c0e13 to f4731a1 Compare January 25, 2026 23:10
@fmease

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment was marked as resolved.

Sign in to view
@fmease
Copy link
Member Author

fmease commented Jan 25, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
@bors
Auto merge of #151660 - fmease:bump-backtrace-demangler-alt, r=<try>
240bbcc 
Bump `std`'s `backtrace`'s `rustc-demangle`
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 26, 2026

☀️ Try build successful (CI)
Build commit: 240bbcc (240bbccbd0c2235c2ed39b1a7d307a56e8634097, parent: 873d4682c7d285540b8f28bfe637006cef8918a6)

This was referenced Jan 26, 2026
Merged
Closed
@fmease fmease marked this pull request as ready for review January 26, 2026 11:33
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

tgross35 commented Jan 26, 2026

Would it make sense to add a test for #151548 here?

@fmease
Copy link
Member Author

fmease commented Jan 28, 2026 •
edited
Loading

Would it make sense to add a test for #151548 here?

We have a UI test for the mangling & demangling of assoc const bindings in the compiler (see). I sure could add a //@ run-crash test to tests/ui/panic/ if you want me to. I just thought it wasn't really worth it for such a niche feature. 🤷 Just let me know if you think otherwise :)

tgross35
tgross35 approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, the chance of backsliding seems rather low and non-catastrophic.

@bors r+

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

📌 Commit f4731a1 has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Symbol of items instantiated w/ dyn trait w/ assoc const bindings not demangled (aka backtrace's rustc-demangle needs to be bumped)

3 participants

@fmease @rustbot @tgross35