Do not suggest derive if there is already an impl
#150720
Merged
+102
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
WhyNovaa
force-pushed
the
diagnostics-impl-fix
branch
from
e01da01 to
197a3ea
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
removed
has-merge-commits
This comment has been minimized.
This comment has been minimized.
WhyNovaa
force-pushed
the
diagnostics-impl-fix
branch
from
197a3ea to
91788da
Compare
Contributor
Author
|
r? @BoxyUwU |
Collaborator
|
|
Kivooeo
reviewed
Jan 6, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
|
r? @lcnr will get to it later this week/start of next |
This comment has been minimized.
This comment has been minimized.
WhyNovaa
force-pushed
the
diagnostics-impl-fix
branch
from
40a83bf to
ed85443
Compare
Member
|
CC'ing brand new PR #151278 for visibility. It attempts to address a related issue. We might or might not be able to share the "core logic" between these two diagnostics (disclaimer: I've only skimmed both PRs, so I might be entirely wrong). |
lcnr
reviewed
Jan 20, 2026
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lcnr
changed the title
derive if there is already an impl
lcnr
reviewed
Jan 27, 2026
lcnr
reviewed
Jan 27, 2026
lcnr
reviewed
Jan 27, 2026
WhyNovaa
force-pushed
the
diagnostics-impl-fix
branch
from
ba92274 to
bd3503d
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
This comment has been minimized.
This comment has been minimized.
WhyNovaa
force-pushed
the
diagnostics-impl-fix
branch
from
daeb392 to
7a4b3ed
Compare
rustbot
removed
has-merge-commits
WhyNovaa
force-pushed
the
diagnostics-impl-fix
branch
from
7a4b3ed to
11ae531
Compare
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
…uwer Rollup of 12 pull requests Successful merges: - #150491 (resolve: Mark items under exported ambiguous imports as exported) - #150720 (Do not suggest `derive` if there is already an impl) - #150968 (compiler-builtins: Remove the no-f16-f128 feature) - #151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain") - #151660 (Bump `std`'s `backtrace`'s `rustc-demangle`) - #151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting) - #151704 (Implement `set_output_kind` for Emscripten linker) - #151706 (Remove Fuchsia from target OS list in unix.rs for sleep) - #151769 (fix undefined behavior in VecDeque::splice) - #151779 (stdarch subtree update) - #151449 ([rustdoc] Add regression test for #151411) - #151773 (clean up checks for constant promotion of integer division/remainder operations)
github-actions bot
pushed a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Jan 29, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#150491 (resolve: Mark items under exported ambiguous imports as exported) - rust-lang/rust#150720 (Do not suggest `derive` if there is already an impl) - rust-lang/rust#150968 (compiler-builtins: Remove the no-f16-f128 feature) - rust-lang/rust#151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain") - rust-lang/rust#151660 (Bump `std`'s `backtrace`'s `rustc-demangle`) - rust-lang/rust#151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting) - rust-lang/rust#151704 (Implement `set_output_kind` for Emscripten linker) - rust-lang/rust#151706 (Remove Fuchsia from target OS list in unix.rs for sleep) - rust-lang/rust#151769 (fix undefined behavior in VecDeque::splice) - rust-lang/rust#151779 (stdarch subtree update) - rust-lang/rust#151449 ([rustdoc] Add regression test for rust-lang/rust#151411) - rust-lang/rust#151773 (clean up checks for constant promotion of integer division/remainder operations)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the compiler would suggest adding
#[derive(Trait)]even if the struct or enum already implements that trait manually.Fixes #146515