Skip to content

Add myself to the review rotation #151349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 19, 2026
Merged

Add myself to the review rotation #151349

rust-bors merged 1 commit into from
Jan 19, 2026

Conversation

@tiif
Copy link
Member

@tiif tiif commented Jan 19, 2026

I was mildly confused about why I never got randomly assigned PR and procrastinated on it 😆 It's time to do it.

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tiif
Copy link
Member Author

tiif commented Jan 19, 2026 •
edited
Loading

I think I can self-approve this PR.

r? me

@rustbot rustbot assigned tiif and unassigned Mark-Simulacrum Jan 19, 2026
@tiif
Copy link
Member Author

tiif commented Jan 19, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

📌 Commit 40691d0 has been approved by tiif

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
@Zalathar Zalathar mentioned this pull request Jan 19, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 19, 2026
@bors
Auto merge of #151352 - Zalathar:rollup-nUIzD3P, r=Zalathar
53b6f89 
Rollup of 4 pull requests

Successful merges:

 - #151080 (fix(build-manifest): enable docs target fallback for `rustc-docs`)
 - #151328 (Fix capitalization of diag messages)
 - #151341 (miri subtree update)
 - #151349 (Add myself to the review rotation)

r? @ghost
@rust-bors rust-bors bot merged commit 1eb8961 into rust-lang:main Jan 19, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 19, 2026
@rust-timer
Unrolled build for #151349
1c960cd 
Rollup merge of #151349 - join-it, r=tiif

Add myself to the review rotation

I was mildly confused about why I never got randomly assigned PR and procrastinated on it 😆 It's time to do it.
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151352 - Zalathar:rollup-nUIzD3P, r=Zalathar
abf29ed 
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151080 (fix(build-manifest): enable docs target fallback for `rustc-docs`)
 - rust-lang/rust#151328 (Fix capitalization of diag messages)
 - rust-lang/rust#151341 (miri subtree update)
 - rust-lang/rust#151349 (Add myself to the review rotation)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tiif tiif

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tiif @rustbot @Mark-Simulacrum