Skip to content

Fix capitalization of diag messages #151328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 2 commits into from
Jan 19, 2026
Merged

Fix capitalization of diag messages #151328

rust-bors merged 2 commits into from
Jan 19, 2026

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jan 18, 2026 •
edited
Loading

Per https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-output-style-guide

Error, Warning, Note, and Help messages start with a lowercase letter and do not end with punctuation.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026
@JonathanBrouwer JonathanBrouwer changed the title Fix capitalization of error messages Fix capitalization of diag messages Jan 18, 2026
Urgau
Urgau approved these changes Jan 18, 2026
View reviewed changes
Copy link
Member

@Urgau Urgau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you. r=me

View changes since this review

@Urgau Urgau self-assigned this Jan 18, 2026
@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review January 18, 2026 21:41
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 18, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jan 18, 2026

@bors r=Urgau rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

📌 Commit f5a1fc7 has been approved by Urgau

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151328 - diag-case, r=Urgau
ae12434 
Fix capitalization of diag messages

Per https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-output-style-guide
> Error, Warning, Note, and Help messages start with a lowercase letter and do not end with punctuation.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 18, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 19, 2026
@bors
Auto merge of #151342 - JonathanBrouwer:rollup-nALcpZn, r=JonathanBro…
e7e5cb1 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #151328 (Fix capitalization of diag messages)
 - #151341 (miri subtree update)

r? @ghost
@Zalathar Zalathar mentioned this pull request Jan 19, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 19, 2026
@bors
Auto merge of #151352 - Zalathar:rollup-nUIzD3P, r=Zalathar
53b6f89 
Rollup of 4 pull requests

Successful merges:

 - #151080 (fix(build-manifest): enable docs target fallback for `rustc-docs`)
 - #151328 (Fix capitalization of diag messages)
 - #151341 (miri subtree update)
 - #151349 (Add myself to the review rotation)

r? @ghost
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 19, 2026
Merged
@rust-bors rust-bors bot merged commit 82db63b into rust-lang:main Jan 19, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
rust-timer added a commit that referenced this pull request Jan 19, 2026
@rust-timer
Unrolled build for #151328
905035b 
Rollup merge of #151328 - diag-case, r=Urgau

Fix capitalization of diag messages

Per https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-output-style-guide
> Error, Warning, Note, and Help messages start with a lowercase letter and do not end with punctuation.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151352 - Zalathar:rollup-nUIzD3P, r=Zalathar
abf29ed 
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151080 (fix(build-manifest): enable docs target fallback for `rustc-docs`)
 - rust-lang/rust#151328 (Fix capitalization of diag messages)
 - rust-lang/rust#151341 (miri subtree update)
 - rust-lang/rust#151349 (Add myself to the review rotation)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JonathanBrouwer @rustbot @Urgau