Skip to content

Conversation

@rami3l
Copy link
Member

@rami3l rami3l commented Jan 13, 2026

Part of rust-lang/rustup#3717.

Closes #150598 by reusing the existing "target fallback" mechanism prepared for rust-docs for rustc-docs as well.

This decision is made because the consensus in both the issue thread and the Zulip thread seems to be that it's okay to distribute a existing prebuilt rustc-docs component in the place of rustc-docs-<host-target> when the latter isn't directly available.

Adjusted the docstrings accordingly following my understanding of the current logic.

cc @jieyouxu

Concerns

  • Can we properly test the effects of this patch before shipping so that I can make sure this is doing the right thing?

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2026
@rami3l
Copy link
Member Author

rami3l commented Jan 18, 2026

Lemme try again, sorry if this is causing trouble for anyone: r? t-bootstrap

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 18, 2026
@rustbot rustbot assigned clubby789 and unassigned Mark-Simulacrum Jan 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

Failed to set assignee to Mark-Simulacrum~~: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@clubby789
Copy link
Contributor

This looks reasonable to me
@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

📌 Commit 596ea17 has been approved by clubby789

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 19, 2026
Rollup of 4 pull requests

Successful merges:

 - #151080 (fix(build-manifest): enable docs target fallback for `rustc-docs`)
 - #151328 (Fix capitalization of diag messages)
 - #151341 (miri subtree update)
 - #151349 (Add myself to the review rotation)

r? @ghost
@rust-bors rust-bors bot merged commit c7e2864 into rust-lang:main Jan 19, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 19, 2026
rust-timer added a commit that referenced this pull request Jan 19, 2026
Rollup merge of #151080 - dist/rustc-docs-target-fallback, r=clubby789

fix(build-manifest): enable docs target fallback for `rustc-docs`
@rami3l rami3l deleted the dist/rustc-docs-target-fallback branch January 19, 2026 12:46
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 20, 2026
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151080 (fix(build-manifest): enable docs target fallback for `rustc-docs`)
 - rust-lang/rust#151328 (Fix capitalization of diag messages)
 - rust-lang/rust#151341 (miri subtree update)
 - rust-lang/rust#151349 (Add myself to the review rotation)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redetermining rustc-docs's target tuple(s)

4 participants