-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
fix(build-manifest): enable docs target fallback for rustc-docs
#151080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rust-bors
merged 1 commit into
rust-lang:main
from
rami3l:dist/rustc-docs-target-fallback
Jan 19, 2026
Merged
fix(build-manifest): enable docs target fallback for rustc-docs
#151080
rust-bors
merged 1 commit into
rust-lang:main
from
rami3l:dist/rustc-docs-target-fallback
Jan 19, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Lemme try again, sorry if this is causing trouble for anyone: r? t-bootstrap |
Collaborator
|
Failed to set assignee to
|
Contributor
|
This looks reasonable to me |
Contributor
rust-timer
added a commit
that referenced
this pull request
Jan 19, 2026
Rollup merge of #151080 - dist/rustc-docs-target-fallback, r=clubby789 fix(build-manifest): enable docs target fallback for `rustc-docs`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 20, 2026
Rollup of 4 pull requests Successful merges: - rust-lang/rust#151080 (fix(build-manifest): enable docs target fallback for `rustc-docs`) - rust-lang/rust#151328 (Fix capitalization of diag messages) - rust-lang/rust#151341 (miri subtree update) - rust-lang/rust#151349 (Add myself to the review rotation) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of rust-lang/rustup#3717.
Closes #150598 by reusing the existing "target fallback" mechanism prepared for
rust-docsforrustc-docsas well.This decision is made because the consensus in both the issue thread and the Zulip thread seems to be that it's okay to distribute a existing prebuilt
rustc-docscomponent in the place ofrustc-docs-<host-target>when the latter isn't directly available.Adjusted the docstrings accordingly following my understanding of the current logic.
cc @jieyouxu
Concerns