Open the FileEncoder file for reading and writing #116067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
approved these changes
Sep 22, 2023
saethlin
force-pushed
the
meta-stats-ice
branch
from
b18fee6
to
4c8ebbe
Compare
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
meta-stats-ice
branch
from
4c8ebbe
to
c3c226a
Compare
This comment has been minimized.
This comment has been minimized.
Noratrieb
reviewed
Sep 22, 2023
saethlin
force-pushed
the
meta-stats-ice
branch
2 times, most recently
from
18029df
to
f7f7d5e
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
meta-stats-ice
branch
from
f7f7d5e
to
09960e0
Compare
|
@bors r=WaffleLapkin |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115770 (Match on elem first while building move paths) - rust-lang#115999 (Capture scrutinee of if let guards correctly) - rust-lang#116056 (Make unsized casts illegal) - rust-lang#116061 (Remove TaKO8Ki from review rotation) - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis) - rust-lang#116067 (Open the FileEncoder file for reading and writing) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
Rollup merge of rust-lang#116067 - saethlin:meta-stats-ice, r=WaffleLapkin Open the FileEncoder file for reading and writing Maybe I just don't know `File` well enough, but the previous comment didn't make it clear enough to me that we can't use `File::create`. This one does. Fixes rust-lang#116055 r? `@WaffleLapkin`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I just don't know
Filewell enough, but the previous comment didn't make it clear enough to me that we can't useFile::create. This one does.Fixes #116055
r? @WaffleLapkin