Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change start to #[start] in some diagnosis #116062

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Change start to #[start] in some diagnosis #116062

merged 1 commit into from
Sep 22, 2023

Conversation

eduardosm
Copy link
Contributor

They refer to a function with the start attribute, but not necessarily named start.

They refer to a function with the `start` attribute, but not necessarily named `start`.
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2023
@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 22, 2023

📌 Commit 17dfabf has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#115770 (Match on elem first while building move paths)
 - rust-lang#115999 (Capture scrutinee of if let guards correctly)
 - rust-lang#116056 (Make unsized casts illegal)
 - rust-lang#116061 (Remove TaKO8Ki from review rotation)
 - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis)
 - rust-lang#116067 (Open the FileEncoder file for reading and writing)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 952d660 into rust-lang:master Sep 22, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 22, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
Rollup merge of rust-lang#116062 - eduardosm:start-fn-diag, r=WaffleLapkin

Change `start` to `#[start]` in some diagnosis

They refer to a function with the `start` attribute, but not necessarily named `start`.
@eduardosm eduardosm deleted the start-fn-diag branch July 18, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants