Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match on elem first while building move paths #115770

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Match on elem first while building move paths #115770

merged 5 commits into from
Sep 22, 2023

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Sep 12, 2023

While working on #115025 @lcnr and I observed "move_paths_for" function matched on the Ty instead of Projection which seems flawed as it's the Projections that cause the problem not the type.

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2023
@ouz-a
Copy link
Contributor Author

ouz-a commented Sep 12, 2023

I think before merging this we should do crater run to make sure it's safe to merge

@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2023
lcnr
lcnr reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nits

compiler/rustc_mir_dataflow/src/move_paths/builder.rs Outdated Show resolved Hide resolved
compiler/rustc_mir_dataflow/src/move_paths/builder.rs Outdated Show resolved Hide resolved
compiler/rustc_mir_dataflow/src/move_paths/builder.rs Show resolved Hide resolved
@ouz-a
Copy link
Contributor Author

ouz-a commented Sep 22, 2023

@bors r= @lcnr

@bors
Copy link
Contributor

bors commented Sep 22, 2023

@ouz-a: 🔑 Insufficient privileges: Not in reviewers

@lcnr
Copy link
Contributor

lcnr commented Sep 22, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 22, 2023

📌 Commit 63df126 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
@bors
Auto merge of rust-lang#116077 - matthiaskrgr:rollup-2y1buzg, r=matth…
e4133ba 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#115770 (Match on elem first while building move paths)
 - rust-lang#115999 (Capture scrutinee of if let guards correctly)
 - rust-lang#116056 (Make unsized casts illegal)
 - rust-lang#116061 (Remove TaKO8Ki from review rotation)
 - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis)
 - rust-lang#116067 (Open the FileEncoder file for reading and writing)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d4d0c84 into rust-lang:master Sep 22, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 22, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
@rust-timer
Unrolled build for rust-lang#115770
7dfa028 
Rollup merge of rust-lang#115770 - ouz-a:match_elem_builder, r=lcnr

Match on elem first while building move paths

While working on rust-lang#115025 `@lcnr` and I observed "move_paths_for" function matched on the `Ty` instead of `Projection` which seems flawed as it's the `Projection`s that cause the problem not the type.

r? `@lcnr`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ouz-a @bors @lcnr @rustbot