Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from highfive to triagebot #103492

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 24, 2022

This migrates rust-lang/rust from highfive to triagebot.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2022
@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Oct 24, 2022
@ehuss ehuss force-pushed the highfive-triagebot branch from 4a48db1 to eaa1b8b Compare October 24, 2022 23:16
@Mark-Simulacrum
Copy link
Member

@bors r+ p=5

Starting to roll this out...

@bors
Copy link
Contributor

bors commented Oct 26, 2022

📌 Commit eaa1b8b has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2022
@Mark-Simulacrum
Copy link
Member

@bors p=10

@bors
Copy link
Contributor

bors commented Oct 26, 2022

⌛ Testing commit eaa1b8b with merge 36285c5...

@bors
Copy link
Contributor

bors commented Oct 26, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 36285c5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2022
@bors bors merged commit 36285c5 into rust-lang:master Oct 26, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 26, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (36285c5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.8% [-0.8%, -0.8%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2022
Add Target Tier Policy notification.

This adds a notification posted to PRs when they add/modify a target spec.

This was hard-coded in highfive. I forgot to include this in rust-lang#103492.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Oct 30, 2022
Add Target Tier Policy notification.

This adds a notification posted to PRs when they add/modify a target spec.

This was hard-coded in highfive. I forgot to include this in rust-lang/rust#103492.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
…ulacrum

Migrate from highfive to triagebot

This migrates rust-lang/rust from highfive to triagebot.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024
Add Target Tier Policy notification.

This adds a notification posted to PRs when they add/modify a target spec.

This was hard-coded in highfive. I forgot to include this in rust-lang/rust#103492.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Add Target Tier Policy notification.

This adds a notification posted to PRs when they add/modify a target spec.

This was hard-coded in highfive. I forgot to include this in rust-lang/rust#103492.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants