suggest type annotation for local statement initialed by ref expression #102951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| let suggest_annotation = match expr.peel_drop_temps().kind { | ||
| hir::ExprKind::AddrOf(hir::BorrowKind::Ref, hir::Mutability::Not, _) => "&", | ||
| hir::ExprKind::AddrOf(hir::BorrowKind::Ref, hir::Mutability::Mut, _) => "&mut ", | ||
| _ => return true, |
There was a problem hiding this comment.
This should return false, since we didn't actually suggest anything I think.
There was a problem hiding this comment.
The err.span_suggestion statement above has made some modifications to err, I guess that might be the reason why we should return true here as well?
There was a problem hiding this comment.
oh, didn't even see that. yeah, makes sense. 👍
|
☔ The latest upstream changes (presumably #103310) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me after rebasing |
SparrowLii
force-pushed
the
type_annotation
branch
from
5cb42dd to
0fca075
Compare
|
@estebank Done. But I don't have the privilege so it still needs you to r+ |
|
@bors r=estebank |
|
@SparrowLii: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r=estebank |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Oct 25, 2022
…bank suggest type annotation for local statement initialed by ref expression In a local statement with a type declaration, if a ref expression is used on the right side and not used on the left side, in addition to removing the `&` and `&mut` on the right side, we can add them on the left side alternatively Fixes rust-lang#102892
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Oct 25, 2022
…bank suggest type annotation for local statement initialed by ref expression In a local statement with a type declaration, if a ref expression is used on the right side and not used on the left side, in addition to removing the `&` and `&mut` on the right side, we can add them on the left side alternatively Fixes rust-lang#102892
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#102951 (suggest type annotation for local statement initialed by ref expression) - rust-lang#103209 (Diagnostic derives: allow specifying multiple alternative suggestions) - rust-lang#103287 (Use a faster allocation size check in slice::from_raw_parts) - rust-lang#103416 (Name the `impl Trait` in region bound suggestions) - rust-lang#103430 (Workaround unstable stmt_expr_attributes for method receiver expressions) - rust-lang#103444 (Remove extra type error after missing semicolon error) - rust-lang#103520 (rustc_middle: Rearrange resolver outputs structures slightly) - rust-lang#103533 (Use &self instead of &mut self for cast methods) - rust-lang#103536 (Remove `rustc_driver::set_sigpipe_handler()`) - rust-lang#103542 (Pinning tests for some `macro_rules!` errors discussed in the lang meeting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
pietroalbini
added a commit
to ferrocene/sphinx-shared-resources
that referenced
this pull request
Mar 22, 2023
600: Pull changes from upstream `master` r=kirtchev-adacore a=pietroalbini * rust-lang/rust#103605 * rust-lang/rust#103604 * rust-lang/rust#103598 * rust-lang/rust#103596 * rust-lang/rust#103580 * rust-lang/rust#103579 * rust-lang/rust#103567 * rust-lang/rust#103558 * rust-lang/rust#103549 * rust-lang/rust#103537 * rust-lang/rust#103526 * rust-lang/rust#103432 * rust-lang/rust#103571 * rust-lang/rust#103492 * rust-lang/rust#103572 * rust-lang/rust#103554 * rust-lang/rust#103546 * rust-lang/rust#103543 * rust-lang/rust#103428 * rust-lang/rust#102706 * rust-lang/rust#95710 * rust-lang/rust#103284 * rust-lang/rust#103562 * rust-lang/rust#103542 * rust-lang/rust#103536 * rust-lang/rust#103533 * rust-lang/rust#103520 * rust-lang/rust#103444 * rust-lang/rust#103430 * rust-lang/rust#103416 * rust-lang/rust#103287 * rust-lang/rust#103209 * rust-lang/rust#102951 * rust-lang/rust#103279 * rust-lang/rust#103158 Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Pietro Albini <[email protected]> Co-authored-by: DropDemBits <[email protected]> Co-authored-by: bors <[email protected]> Co-authored-by: Pietro Albini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a local statement with a type declaration, if a ref expression is used on the right side and not used on the left side, in addition to removing the
&and&muton the right side, we can add them on the left side alternativelyFixes #102892