Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the redundant Some(try_opt!(..)) in checked_pow #103159

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Remove the redundant Some(try_opt!(..)) in checked_pow #103159

merged 1 commit into from
Oct 18, 2022

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 17, 2022

The final return value doesn't need to be tried at all -- we can just
return the checked option directly. The optimizer can probably figure
this out anyway, but there's no need to make it work here.

@cuviper
Remove the redundant Some(try_opt!(..)) in checked_pow
d7fd1d5 
The final return value doesn't need to be tried at all -- we can just
return the checked option directly. The optimizer can probably figure
this out anyway, but there's no need to make it work here.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 17, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 17, 2022

📌 Commit d7fd1d5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 18, 2022
@Dylan-DPC
Rollup merge of rust-lang#103159 - cuviper:check_pow-final-try_opt, r…
b753ffd 
…=Mark-Simulacrum

Remove the redundant `Some(try_opt!(..))` in `checked_pow`

The final return value doesn't need to be tried at all -- we can just
return the checked option directly. The optimizer can probably figure
this out anyway, but there's no need to make it work here.
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 18, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 18, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2022
@bors
Auto merge of rust-lang#103188 - JohnTitor:rollup-pwilam1, r=JohnTitor
e94827e 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#103023 (Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases)
 - rust-lang#103142 (Make diagnostic for unsatisfied `Termination` bounds more precise)
 - rust-lang#103154 (Fix typo in `ReverseSearcher` docs)
 - rust-lang#103159 (Remove the redundant `Some(try_opt!(..))` in `checked_pow`)
 - rust-lang#103163 (Remove all uses of array_assume_init)
 - rust-lang#103168 (Stabilize asm_sym)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e04bbcb into rust-lang:master Oct 18, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 18, 2022
@cuviper cuviper deleted the check_pow-final-try_opt branch October 18, 2022 18:54
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#103188 - JohnTitor:rollup-pwilam1, r=JohnTitor
3909bc1 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#103023 (Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases)
 - rust-lang#103142 (Make diagnostic for unsatisfied `Termination` bounds more precise)
 - rust-lang#103154 (Fix typo in `ReverseSearcher` docs)
 - rust-lang#103159 (Remove the redundant `Some(try_opt!(..))` in `checked_pow`)
 - rust-lang#103163 (Remove all uses of array_assume_init)
 - rust-lang#103168 (Stabilize asm_sym)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @rust-highfive @rustbot @Mark-Simulacrum @bors