-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fuchsia-ignore
and needs-unwind
to compiler test cases
#103023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Oct 13, 2022
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2022
tmandry
reviewed
Oct 18, 2022
@@ -1,4 +1,5 @@ | |||
// run-pass | |||
// ignore-fuchsia Test must be run out-of-process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be needs-unwind
? Or I don't understand what the comment means, anyway. I'm not sure if bench works with panic=abort.
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 18, 2022
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Oct 18, 2022
…tmandry Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases Final tests covering missing privileges r? `@tmandry` cc. `@djkoloski`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#103023 (Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases) - rust-lang#103142 (Make diagnostic for unsatisfied `Termination` bounds more precise) - rust-lang#103154 (Fix typo in `ReverseSearcher` docs) - rust-lang#103159 (Remove the redundant `Some(try_opt!(..))` in `checked_pow`) - rust-lang#103163 (Remove all uses of array_assume_init) - rust-lang#103168 (Stabilize asm_sym) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…tmandry Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases Final tests covering missing privileges r? ``@tmandry`` cc. ``@djkoloski``
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#103023 (Adding `fuchsia-ignore` and `needs-unwind` to compiler test cases) - rust-lang#103142 (Make diagnostic for unsatisfied `Termination` bounds more precise) - rust-lang#103154 (Fix typo in `ReverseSearcher` docs) - rust-lang#103159 (Remove the redundant `Some(try_opt!(..))` in `checked_pow`) - rust-lang#103163 (Remove all uses of array_assume_init) - rust-lang#103168 (Stabilize asm_sym) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-fuchsia
Operating system: Fuchsia
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final tests covering missing privileges
r? @tmandry
cc. @djkoloski