Improve -Zhir-stats
#100398
Merged
Improve -Zhir-stats
#100398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be very useful in subsequent commits where I will improve the output.
This commit: - Adds a comment explaining which `visit_*` methods should be implemented. - Adds and removes some `visit_*` methods accordingly, improving coverage, and avoiding some double counting.
Currently it's reported as either `TraitItem` or `ImplItem`. This commit changes it to `AssocItem`, because having the report match the type name is (a) consistent with other types, and (b) the trait/impl split isn't that important here.
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
Thanks for the PR, @nnethercote! This looks useful indeed.
I left a comment about a possible simplification below. Otherwise, feel free to r=me.
This tells you which variants of the enums are most common, which is very useful. I've only done it for the AST for now, HIR can be done later.
nnethercote
force-pushed
the
improve-Zhir-stats
branch
from
193d1b3
to
4f8a170
Compare
|
I made the suggested simplification. @bors r=michaelwoerister |
bors
added
S-waiting-on-bors
|
@bors rollup=always Because these code changes are all behind the |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2022
Rollup of 11 pull requests Successful merges: - rust-lang#92744 (Check if enum from foreign crate has any non exhaustive variants when attempting a cast) - rust-lang#99110 (Determine match_has_guard from candidates instead of looking up thir table again) - rust-lang#100184 (Stabilize ptr_const_cast) - rust-lang#100192 ( Remove duplicated temporaries creating during box derefs elaboration) - rust-lang#100232 (Do not consider method call receiver as an argument in AST.) - rust-lang#100287 (linux: Use `pthread_setname_np` instead of `prctl`) - rust-lang#100351 (Use `&mut Diagnostic` instead of `&mut DiagnosticBuilder` unless needed) - rust-lang#100370 (Remove more Clean trait implementations) - rust-lang#100391 (Improve size assertions) - rust-lang#100398 (Improve `-Zhir-stats`) - rust-lang#100403 (Improve error messages when running rustdoc GUI tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 5, 2022
…avidtwco Improve HIR stats rust-lang#100398 improve the AST stats collection done by `-Zhir-stats`. This PR does the same for HIR stats collection. r? `@davidtwco`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 9, 2022
…avidtwco Improve HIR stats rust-lang#100398 improve the AST stats collection done by `-Zhir-stats`. This PR does the same for HIR stats collection. r? `@davidtwco`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing, improve coverage, avoid some double counting, and add more detail.
r? @michaelwoerister