Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize ptr_const_cast #100184

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Stabilize ptr_const_cast #100184

merged 1 commit into from
Aug 11, 2022

Conversation

Kixunil
Copy link
Contributor

@Kixunil Kixunil commented Aug 5, 2022

This stabilizes ptr_const_cast feature as was decided in a recent
FCP

Closes #92675

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 5, 2022
@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2022
@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 5, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 5, 2022
@Kixunil Kixunil force-pushed the stabilize_ptr_const_cast branch from 1d3d615 to 0e5d0e6 Compare August 5, 2022 22:34
@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 8, 2022

r? @thomcc

Looks like others are on holiday or something, hope this is OK.

@rust-highfive rust-highfive assigned thomcc and unassigned m-ou-se Aug 8, 2022
scottmcm
scottmcm reviewed Aug 10, 2022
View reviewed changes
library/core/src/ptr/const_ptr.rs Outdated
#[unstable(feature = "ptr_const_cast", issue = "92675")]
#[rustc_const_unstable(feature = "ptr_const_cast", issue = "92675")]
#[stable(feature = "ptr_const_cast", since = "1.64.0")]
#[rustc_const_stable(feature = "ptr_const_cast", since = "1.64.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this missed 1.64, so will need to be 1.65 now: https://github.com/rust-lang/rust/blob/master/src/version

@Kixunil Kixunil force-pushed the stabilize_ptr_const_cast branch from 0e5d0e6 to a8d32cd Compare August 10, 2022 15:22
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2022

The Miri submodule was changed

cc @rust-lang/miri

Some changes occurred in src/tools/cargo

cc @ehuss

@Kixunil
Stabilize ptr_const_cast
2a3ce78 
This stabilizes `ptr_const_cast` feature as was decided in a recent
[FCP](rust-lang#92675 (comment))

Closes rust-lang#92675
@Kixunil Kixunil force-pushed the stabilize_ptr_const_cast branch from a8d32cd to 2a3ce78 Compare August 10, 2022 15:24
@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 10, 2022

@rustbot label -A-bootstrap

Sorry for the noise, submodules are annoying.

@rustbot rustbot removed the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 10, 2022
@thomcc
Copy link
Member

thomcc commented Aug 10, 2022

I'm not t-libs-api so the original reviewer was better, sorry.

r? @m-ou-se

@rust-highfive rust-highfive assigned m-ou-se and unassigned thomcc Aug 10, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Aug 11, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 11, 2022

📌 Commit 2a3ce78 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2022
@bors
Auto merge of rust-lang#100416 - Dylan-DPC:rollup-m344lh1, r=Dylan-DPC
20ffea6 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#92744 (Check if enum from foreign crate has any non exhaustive variants when attempting a cast)
 - rust-lang#99110 (Determine match_has_guard from candidates instead of looking up thir table again)
 - rust-lang#100184 (Stabilize ptr_const_cast)
 - rust-lang#100192 ( Remove duplicated temporaries creating during box derefs elaboration)
 - rust-lang#100232 (Do not consider method call receiver as an argument in AST.)
 - rust-lang#100287 (linux: Use `pthread_setname_np` instead of `prctl`)
 - rust-lang#100351 (Use `&mut Diagnostic` instead of `&mut DiagnosticBuilder` unless needed)
 - rust-lang#100370 (Remove more Clean trait implementations)
 - rust-lang#100391 (Improve size assertions)
 - rust-lang#100398 (Improve `-Zhir-stats`)
 - rust-lang#100403 (Improve error messages when running rustdoc GUI tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d749914 into rust-lang:master Aug 11, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 11, 2022
@Kixunil Kixunil deleted the stabilize_ptr_const_cast branch August 11, 2022 23:07
@gmmyung gmmyung mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmcm scottmcm scottmcm left review comments

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for ptr_const_cast
7 participants
@Kixunil @rust-highfive @rustbot @thomcc @m-ou-se @bors @scottmcm