Improve HIR stats #101142
Merged
Improve HIR stats #101142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on `-Zprint-type-sizes` which does the same thing. It makes the output provenance clearer, and helps with post-processing. E.g. if you have `-Zhir-stats` output from numerous compiler invocations you can now easily extract the pre-expansion stats separately from the post-expansion stats.
For consistency, and because it makes HIR measurement simpler and more accurate.
For consistency, and because it makes HIR measurement simpler and more accurate.
For consistency, and because it makes HIR measurement simpler and more accurate.
This comment on the HIR `visit_path_segment` is supposed be on the AST `visit_path_segment`.
Because `hir_id` is the standard name for methods that return a `HirId` from a HIR node.
Adds and removes some `visit_*` methods accordingly, improving coverage, and avoiding some double counting. Brings it in line with the AST stats collector.
rustbot
added
the
T-compiler
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
|
Best reviewed one commit at a time. |
|
I learned that @michaelwoerister is on leave. Let's try another reviewer. r? @davidtwco |
davidtwco
approved these changes
Sep 2, 2022
| @@ -416,7 +416,7 @@ pub fn configure_and_expand( | |||
| } | |||
|
|
|||
| if sess.opts.unstable_opts.hir_stats { | |||
| hir_stats::print_ast_stats(&krate, "POST EXPANSION AST STATS"); | |||
| hir_stats::print_ast_stats(&krate, "POST EXPANSION AST STATS", "ast-stats-2"); | |||
There was a problem hiding this comment.
nit: ast-stats-2 could probably be ast-post-stats or something a little more descriptive? Likewise with ast-stats-1.
There was a problem hiding this comment.
I'll leave it as is. Anything short of ast-stats-{pre,post}-expansion is going to be non-obvious to a first-time user, but that's a bit on the long side. And the heading ensures that a first-time user will be able to quickly work out the meaning of the 1 and 2.
|
@bors r=davidtwco |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#101142 (Improve HIR stats) - rust-lang#101367 (Suggest `{Option,Result}::{copied,clone}()` to satisfy type mismatch) - rust-lang#101391 (more clippy::perf fixes) - rust-lang#101409 (Don't fire `rust_2021_incompatible_closure_captures` in `edition = 2021` crates) - rust-lang#101420 (Fix `hir::Local` doc to match with the variable name used: `init`) - rust-lang#101429 (Don't suggest reborrow if usage is inside a closure) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 9, 2022
…avidtwco Improve HIR stats rust-lang#100398 improve the AST stats collection done by `-Zhir-stats`. This PR does the same for HIR stats collection. r? `@davidtwco`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#100398 improve the AST stats collection done by
-Zhir-stats. This PR does the same for HIR stats collection.r? @davidtwco