fix changing versions not keeping the paths #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
|
Thanks for the fix. Agreed, a lot of logic is duplicated in a few places, would be nice to centralize it. Also please add a test to prevent this regression from happening again. |
|
( forget it, found the existing tests) |
|
@GuillaumeGomez I added a short test for the partial |
syphar
force-pushed
the
fix-release-list-try1
branch
from
4da711c
to
be5dfca
Compare
syphar
force-pushed
the
fix-release-list-try1
branch
from
be5dfca
to
ff21579
Compare
|
Also I just rebased on master and adapted the initial commit based on the changes in #2325 |
syphar
force-pushed
the
fix-release-list-try1
branch
from
ff21579
to
24cc0a8
Compare
GuillaumeGomez
approved these changes
Dec 8, 2023
|
Looks all good to me, thanks! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression from #2113 , fixes #2349
This fix here is mostly copying logic from the
get_all_platforms_innermethod in this module.I'm seeing that plenty of logic around version-matching is duplicated between handlers, and will try to find a way to refactor this. Also the URL-Patterns for the target-redirect lead to the handler itself being quite complex, perhaps we could just use GET parameters there. ( also separate IMO).