-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load release list only when needed #2113
Load release list only when needed #2113
Conversation
ab1da03
to
85cd7ca
Compare
I finished porting the code so now JS generates the same thing as jinja used to. The problem now is that some tests relied on the DOM content to check some things, which isn't possible anymore. We could however have the failing tests ported to some "front-end testing"like what #1698 proposes. |
Rather than doing client-side rendering of json, we could just serve a partial-page of HTML that gets inserted in the DOM, that might be easier to migrate the existing tests to too. |
That would indeed make it much simpler to maintain and we could directly re-use the existing template. 👍 |
d1c2a20
to
0525f8f
Compare
I applied suggestions: this path now returns HTML which is directly inserted into the DOM, allowing to greatly simplify the code and also minimize the impact on tests. |
@Nemo157: Anything else that needs to be done here? |
0525f8f
to
0bbcc88
Compare
Applied suggestions. |
It was something we discussed some time ago. Instead of loading the release list all the time, with this PR it's only loaded when the menu is opened. It should greatly reduce the page size on crates with a lot of releases.
Original issue: #1999
cc @Nemo157 @jsha