Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing versions doesn't stay on same item #2349

Closed
jsha opened this issue Nov 30, 2023 · 3 comments · Fixed by #2355
Closed

Changing versions doesn't stay on same item #2349

jsha opened this issue Nov 30, 2023 · 3 comments · Fixed by #2355

Comments

@jsha
Copy link
Contributor

jsha commented Nov 30, 2023

Steps to reproduce:

  1. Visit https://docs.rs/rustls/latest/rustls/struct.ConfigBuilder.html
  2. Click the crate name in the topbar to open the menu
  3. Select a different version (e.g. 0.21.9)

Expected result:

Wind up on https://docs.rs/rustls/0.21.9/rustls/struct.ConfigBuilder.html, that is, the same page in a different version.

Actual result:

Wind up on https://docs.rs/rustls/0.21.9/rustls/index.html, the index page.

@syphar
Copy link
Member

syphar commented Dec 1, 2023

I can definitely reproduce this, and it's odd that this stopped working, I remember these parts are more thoroughly tested than others, but also both the rustdoc-redirect-handler & the rustdoc-page handler are relatively complex.

@syphar
Copy link
Member

syphar commented Dec 1, 2023

this is a regression coming from #2113, cc @GuillaumeGomez @Nemo157

I'll see if I can figure out the solution with my limited JS knowledge

@syphar
Copy link
Member

syphar commented Dec 1, 2023

it also switches back to the default target instead of keeping the currently selected target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants