Don't make calls to the database in for loops

[jyn514]

This is a low-priority issue, we should fix #379 and #343 first.

This came up while reviewing #529. Offenders:

• add_owners_into_database
• add_package_into_database (not the same but related)
• add_keywords_into_database
• add_authors_into_database
• add_path_into_database

[jyn514]

@syphar are you interested in taking a look at this? I don't want to burden you with too much work, but it seems right up your alley :)

[syphar]

It's definitely my alley :)

Actually I'm not sure why I already saw and fixed it when I looked through all issues :)

[syphar]

on current master, it looks like the remaining fixes are:

• update_owners_in_database
• add_keywords_into_database
• add_compression_into_database

I'll start with these, and other small optimizations I find in db::add_package.

Can you elaborate where you see an issue with add_path_into_database or add_package_into_database?

[jyn514]

add_path_into_database is very different now, most of it is in the storage module. I don't see anything in storage that looks bad off the top of my head (and performance doesn't matter for the test database anyway, only for S3).

I don't remember what I was thinking about add_package_into_database. Maybe I wanted to combine everything into a database transaction? That's already tracked at #1071.

[syphar]

I'll leave add_compression_into_database as it is, it's only one record in all our cases.