Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use database transactions for builds #1071

Closed
jyn514 opened this issue Sep 30, 2020 · 1 comment
Closed

Use database transactions for builds #1071

jyn514 opened this issue Sep 30, 2020 · 1 comment
Labels
A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 30, 2020

This would have avoided the panic found in #1035.
@jyn514 jyn514 added C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users A-builds Area: Building the documentation for a crate labels Sep 30, 2020
@jyn514 jyn514 mentioned this issue Apr 18, 2021
Closed
@syphar
Copy link
Member

syphar commented Aug 3, 2023

I'm not sure this is a good idea anymore,

seeing #1011 I would imagine that we record intermediate build steps in the database, which wouldn't work with packing all into one transaction.

I'll close this issue, we can totally reopen when we need this, or if I misunderstood #1035 .

@syphar syphar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syphar @jyn514