delete-crate command #529
Merged
delete-crate command #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when testing against play.minio.io, as it requires the us-east-1 region name.
Without this commit debugging S3 upload errors is a pain, as there is no way to see them.
I think someone mentioned removing only specific versions at some point, is that still something that's planned? That doesn't need to block this PR, but it would be nice to keep in the background. |
I don't think we need this at the moment, we can think about that when it's needed. |
pietroalbini
force-pushed
the
delete-crate
branch
2 times, most recently
from
006eaac
to
6221459
Compare
pietroalbini
force-pushed
the
delete-crate
branch
from
6221459
to
82cc5cd
Compare
|
This is ready for review. |
jyn514
reviewed
Dec 19, 2019
Co-Authored-By: Joshua Nelson <[email protected]>
|
Replied to or addressed all the comments. |
jyn514
reviewed
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command to the CLI:
The command will remove all the published versions of a crate, both from the database and S3.
Fixes #528